From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>, Jiri Slaby <jslaby@suse.cz>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] intel_ips: potential null dereference
Date: Sat, 07 Aug 2010 23:48:53 +0000 [thread overview]
Message-ID: <20100807164853.4c3818c9@virtuousgeek.org> (raw)
In-Reply-To: <20100807215703.GA9031@bicker>
On Sun, 8 Aug 2010 00:01:12 +0200
Dan Carpenter <error27@gmail.com> wrote:
> There is a potential NULL dereference of "limits." We can just return
> NULL earlier to avoid it. The caller already handles NULL returns.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index afe82e5..c908048 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1342,8 +1342,10 @@ static struct ips_mcp_limits *ips_detect_cpu(struct ips_driver *ips)
> limits = &ips_lv_limits;
> else if (strstr(boot_cpu_data.x86_model_id, "CPU U"))
> limits = &ips_ulv_limits;
> - else
> + else {
> dev_info(&ips->dev->dev, "No CPUID match found.\n");
> + goto out;
> + }
>
> rdmsrl(TURBO_POWER_CURRENT_LIMIT, turbo_power);
> tdp = turbo_power & TURBO_TDP_MASK;
Yep, good idea to catch this case.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>, Jiri Slaby <jslaby@suse.cz>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] intel_ips: potential null dereference
Date: Sat, 7 Aug 2010 16:48:53 -0700 [thread overview]
Message-ID: <20100807164853.4c3818c9@virtuousgeek.org> (raw)
In-Reply-To: <20100807215703.GA9031@bicker>
On Sun, 8 Aug 2010 00:01:12 +0200
Dan Carpenter <error27@gmail.com> wrote:
> There is a potential NULL dereference of "limits." We can just return
> NULL earlier to avoid it. The caller already handles NULL returns.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index afe82e5..c908048 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1342,8 +1342,10 @@ static struct ips_mcp_limits *ips_detect_cpu(struct ips_driver *ips)
> limits = &ips_lv_limits;
> else if (strstr(boot_cpu_data.x86_model_id, "CPU U"))
> limits = &ips_ulv_limits;
> - else
> + else {
> dev_info(&ips->dev->dev, "No CPUID match found.\n");
> + goto out;
> + }
>
> rdmsrl(TURBO_POWER_CURRENT_LIMIT, turbo_power);
> tdp = turbo_power & TURBO_TDP_MASK;
Yep, good idea to catch this case.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-08-07 23:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 22:01 [patch] intel_ips: potential null dereference Dan Carpenter
2010-08-07 22:01 ` Dan Carpenter
2010-08-07 23:48 ` Jesse Barnes [this message]
2010-08-07 23:48 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100807164853.4c3818c9@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=error27@gmail.com \
--cc=jslaby@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.