* [patch] bfa: dereferencing before testing
@ 2010-08-07 22:13 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-08-07 22:13 UTC (permalink / raw)
To: Jing Huang
Cc: James E.J. Bottomley, Krishna Gudipati, linux-scsi, linux-kernel,
kernel-janitors
I moved the dereference of "port" after the check to verify it was
non-NULL.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/scsi/bfa/lport_api.c b/drivers/scsi/bfa/lport_api.c
index 72b3f50..5cd356a 100644
--- a/drivers/scsi/bfa/lport_api.c
+++ b/drivers/scsi/bfa/lport_api.c
@@ -149,11 +149,12 @@ bfa_fcs_port_get_rport_max_speed(struct bfa_fcs_port_s *port)
enum bfa_pport_speed max_speed = 0;
struct bfa_pport_attr_s pport_attr;
enum bfa_pport_speed pport_speed, rport_speed;
- bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+ bfa_boolean_t trl_enabled;
if (port = NULL)
return 0;
+ trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
fcs = port->fcs;
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] bfa: dereferencing before testing
@ 2010-08-07 22:13 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-08-07 22:13 UTC (permalink / raw)
To: Jing Huang
Cc: James E.J. Bottomley, Krishna Gudipati, linux-scsi, linux-kernel,
kernel-janitors
I moved the dereference of "port" after the check to verify it was
non-NULL.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/scsi/bfa/lport_api.c b/drivers/scsi/bfa/lport_api.c
index 72b3f50..5cd356a 100644
--- a/drivers/scsi/bfa/lport_api.c
+++ b/drivers/scsi/bfa/lport_api.c
@@ -149,11 +149,12 @@ bfa_fcs_port_get_rport_max_speed(struct bfa_fcs_port_s *port)
enum bfa_pport_speed max_speed = 0;
struct bfa_pport_attr_s pport_attr;
enum bfa_pport_speed pport_speed, rport_speed;
- bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+ bfa_boolean_t trl_enabled;
if (port == NULL)
return 0;
+ trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
fcs = port->fcs;
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-07 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-07 22:13 [patch] bfa: dereferencing before testing Dan Carpenter
2010-08-07 22:13 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.