From: Dan Carpenter <error27@gmail.com>
To: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Cc: Amit Salecha <amit.salecha@qlogic.com>,
Linux Driver <Linux-Driver@qlogic.com>,
"David S. Miller" <davem@davemloft.net>,
Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch 2/2] qlcnic: using too much stack
Date: Mon, 09 Aug 2010 18:42:54 +0000 [thread overview]
Message-ID: <20100809184254.GJ9031@bicker> (raw)
In-Reply-To: <0081C370-65E2-434F-BBC6-C688F6F39750@qlogic.com>
On Mon, Aug 09, 2010 at 09:46:32AM -0700, Anirban Chakraborty wrote:
>
> It looks fine except that I'd use kzalloc instead of kcalloc above.
>
It's no problem to do that, and I'm already respinning the patches but
I'm confused. It looks like pci_info gets initialized correctly. What
am I missing?
regards,
dan carpenter
> thanks,
> -Anirban
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Cc: Amit Salecha <amit.salecha@qlogic.com>,
Linux Driver <Linux-Driver@qlogic.com>,
"David S. Miller" <davem@davemloft.net>,
Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch 2/2] qlcnic: using too much stack
Date: Mon, 9 Aug 2010 20:42:54 +0200 [thread overview]
Message-ID: <20100809184254.GJ9031@bicker> (raw)
In-Reply-To: <0081C370-65E2-434F-BBC6-C688F6F39750@qlogic.com>
On Mon, Aug 09, 2010 at 09:46:32AM -0700, Anirban Chakraborty wrote:
>
> It looks fine except that I'd use kzalloc instead of kcalloc above.
>
It's no problem to do that, and I'm already respinning the patches but
I'm confused. It looks like pci_info gets initialized correctly. What
am I missing?
regards,
dan carpenter
> thanks,
> -Anirban
next prev parent reply other threads:[~2010-08-09 18:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 10:37 [patch 2/2] qlcnic: using too much stack Dan Carpenter
2010-08-09 10:37 ` Dan Carpenter
2010-08-09 16:46 ` Anirban Chakraborty
2010-08-09 16:46 ` Anirban Chakraborty
2010-08-09 18:42 ` Dan Carpenter [this message]
2010-08-09 18:42 ` Dan Carpenter
2010-08-10 1:43 ` Anirban Chakraborty
2010-08-10 1:43 ` Anirban Chakraborty
2010-08-10 2:03 ` Joe Perches
2010-08-10 2:03 ` Joe Perches
2010-08-10 3:31 ` Anirban Chakraborty
2010-08-10 3:31 ` Anirban Chakraborty
2010-08-10 3:39 ` Joe Perches
2010-08-10 3:39 ` Joe Perches
2010-08-10 7:01 ` David Miller
2010-08-10 7:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809184254.GJ9031@bicker \
--to=error27@gmail.com \
--cc=Linux-Driver@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sucheta.chakraborty@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.