From: "Ted Ts'o" <tytso@mit.edu>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
dingdinghua <dingdinghua@nrchpc.ac.cn>,
Joel Becker <joel.becker@oracle.com>,
Mark Fasheh <mfasheh@suse.com>,
linux-ext4@vger.kernel.org,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] jbd2: fix warning if CONFIG_JBD2_DEBUG is not used
Date: Wed, 11 Aug 2010 03:07:20 +0000 [thread overview]
Message-ID: <20100811030720.GO3635@thunk.org> (raw)
In-Reply-To: <1281490742.4423.10.camel@lovely.krouter>
On Wed, Aug 11, 2010 at 03:39:02AM +0200, Christoph Fritz wrote:
> Commit 8dd420466c7bfc459fa04680bd5690bfc41a4553 makes variable ts unused
> when CONFIG_JBD2_DEBUG is not used. This patch ifdefs it too.
>
> fs/jbd2/transaction.c: In function ‘start_this_handle’:
> fs/jbd2/transaction.c:98: warning: unused variable ‘ts’
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
I have a patch queued up to fix this already, using an approach
suggested by Linus.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Ted Ts'o <tytso@mit.edu>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
dingdinghua <dingdinghua@nrchpc.ac.cn>,
Joel Becker <joel.becker@oracle.com>,
Mark Fasheh <mfasheh@suse.com>,
linux-ext4@vger.kernel.org,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] jbd2: fix warning if CONFIG_JBD2_DEBUG is not used
Date: Tue, 10 Aug 2010 23:07:20 -0400 [thread overview]
Message-ID: <20100811030720.GO3635@thunk.org> (raw)
In-Reply-To: <1281490742.4423.10.camel@lovely.krouter>
On Wed, Aug 11, 2010 at 03:39:02AM +0200, Christoph Fritz wrote:
> Commit 8dd420466c7bfc459fa04680bd5690bfc41a4553 makes variable ts unused
> when CONFIG_JBD2_DEBUG is not used. This patch ifdefs it too.
>
> fs/jbd2/transaction.c: In function ‘start_this_handle’:
> fs/jbd2/transaction.c:98: warning: unused variable ‘ts’
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
I have a patch queued up to fix this already, using an approach
suggested by Linus.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-11 3:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 1:39 [PATCH] jbd2: fix warning if CONFIG_JBD2_DEBUG is not used Christoph Fritz
2010-08-11 1:39 ` Christoph Fritz
2010-08-11 3:07 ` Ted Ts'o [this message]
2010-08-11 3:07 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100811030720.GO3635@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=chf.fritz@googlemail.com \
--cc=dingdinghua@nrchpc.ac.cn \
--cc=joel.becker@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=mfasheh@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.