All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] drbd: cleanup: change "<= 0" to "== 0"
Date: Wed, 11 Aug 2010 22:38:45 +0000	[thread overview]
Message-ID: <20100811223845.GE645@bicker> (raw)

dt is unsigned so it's never less than zero.  We are calculating the
elapsed time, and that's never less than zero (unless there is a bug or
we invent time travel).  The comparison here is just to guard against
divide by zero bugs.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
index be3374b..4c0c4aa 100644
--- a/drivers/block/drbd/drbd_proc.c
+++ b/drivers/block/drbd/drbd_proc.c
@@ -118,7 +118,7 @@ static void drbd_syncer_progress(struct drbd_conf *mdev, struct seq_file *seq)
 	/* mean speed since syncer started
 	 * we do account for PausedSync periods */
 	dt = (jiffies - mdev->rs_start - mdev->rs_paused) / HZ;
-	if (dt <= 0)
+	if (dt = 0)
 		dt = 1;
 	db = mdev->rs_total - rs_left;
 	dbdt = Bit2KB(db/dt);

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Jens Axboe <jaxboe@fusionio.com>,
	kernel-janitors@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
	Philipp Reisner <philipp.reisner@linbit.com>,
	drbd-user@lists.linbit.com
Subject: [Drbd-dev] [patch] drbd: cleanup: change "<= 0" to "== 0"
Date: Thu, 12 Aug 2010 00:38:45 +0200	[thread overview]
Message-ID: <20100811223845.GE645@bicker> (raw)

dt is unsigned so it's never less than zero.  We are calculating the
elapsed time, and that's never less than zero (unless there is a bug or
we invent time travel).  The comparison here is just to guard against
divide by zero bugs.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
index be3374b..4c0c4aa 100644
--- a/drivers/block/drbd/drbd_proc.c
+++ b/drivers/block/drbd/drbd_proc.c
@@ -118,7 +118,7 @@ static void drbd_syncer_progress(struct drbd_conf *mdev, struct seq_file *seq)
 	/* mean speed since syncer started
 	 * we do account for PausedSync periods */
 	dt = (jiffies - mdev->rs_start - mdev->rs_paused) / HZ;
-	if (dt <= 0)
+	if (dt == 0)
 		dt = 1;
 	db = mdev->rs_total - rs_left;
 	dbdt = Bit2KB(db/dt);

             reply	other threads:[~2010-08-11 22:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11 22:38 Dan Carpenter [this message]
2010-08-11 22:38 ` [Drbd-dev] [patch] drbd: cleanup: change "<= 0" to "== 0" Dan Carpenter
2010-08-23 10:34 ` Jens Axboe
2010-08-23 10:34   ` [Drbd-dev] " Jens Axboe
2010-08-23 16:03 ` Philipp Reisner
2010-08-23 16:03   ` [Drbd-dev] " Philipp Reisner
2010-08-24  8:38 ` Philipp Reisner
2010-08-24  8:38   ` [Drbd-dev] " Philipp Reisner
2010-08-24  8:41 ` Jens Axboe
2010-08-24  8:41   ` [Drbd-dev] " Jens Axboe
2010-08-24  9:10 ` Philipp Reisner
2010-08-24  9:10   ` [Drbd-dev] " Philipp Reisner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100811223845.GE645@bicker \
    --to=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.