From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix gen_nand probe structures contents
Date: Thu, 12 Aug 2010 04:43:24 +0200 [thread overview]
Message-ID: <201008120443.24749.marek.vasut@gmail.com> (raw)
In-Reply-To: <1281576112.12475.15.camel@localhost>
Dne ?t 12. srpna 2010 03:21:52 David Woodhouse napsal(a):
> On Thu, 2010-08-12 at 02:14 +0100, Marek Vasut wrote:
> > These three platforms didn't properly fill nr_chips in gen_nand
> > registration and
> > therefore depended on gen_nand bug fixed by the following patch:
> >
> > "mtd: gen_nand: fix support for multiple chips"
> >
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>
> Thanks. I've applied that to the mtd-2.6.git tree, which has a few
> straggling commits I'll be asking Linus to pull shortly.
>
> In case there are any more, would you care to complement it with a check
> in the driver that detects the nonsensical case of nr_chips == 0,
> assumes it means 1, and also warns about it?
I checked whole arch-arm and there are no more. nr_chips check would be a nice
thing, I was thinking of it already when I sent the first patch. I just checked
the other archs and there are more breaks. I'll implement the check in a
separate patch.
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"nico@fluxnic.net" <nico@fluxnic.net>,
"kernel@wantstofly.org" <kernel@wantstofly.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"kaloz@openwrt.org" <kaloz@openwrt.org>,
"khc@pm.waw.pl" <khc@pm.waw.pl>, "tj@kernel.org" <tj@kernel.org>,
"gregkh@suse.de" <gregkh@suse.de>,
"stable-review@kernel.org" <stable-review@kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
"Artem.Bityutskiy@nokia.com" <Artem.Bityutskiy@nokia.com>
Subject: Re: [PATCH] ARM: Fix gen_nand probe structures contents
Date: Thu, 12 Aug 2010 04:43:24 +0200 [thread overview]
Message-ID: <201008120443.24749.marek.vasut@gmail.com> (raw)
In-Reply-To: <1281576112.12475.15.camel@localhost>
Dne Čt 12. srpna 2010 03:21:52 David Woodhouse napsal(a):
> On Thu, 2010-08-12 at 02:14 +0100, Marek Vasut wrote:
> > These three platforms didn't properly fill nr_chips in gen_nand
> > registration and
> > therefore depended on gen_nand bug fixed by the following patch:
> >
> > "mtd: gen_nand: fix support for multiple chips"
> >
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>
> Thanks. I've applied that to the mtd-2.6.git tree, which has a few
> straggling commits I'll be asking Linus to pull shortly.
>
> In case there are any more, would you care to complement it with a check
> in the driver that detects the nonsensical case of nr_chips == 0,
> assumes it means 1, and also warns about it?
I checked whole arch-arm and there are no more. nr_chips check would be a nice
thing, I was thinking of it already when I sent the first patch. I just checked
the other archs and there are more breaks. I'll implement the check in a
separate patch.
next prev parent reply other threads:[~2010-08-12 2:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 1:14 [PATCH] ARM: Fix gen_nand probe structures contents Marek Vasut
2010-08-12 1:14 ` Marek Vasut
2010-08-12 1:21 ` David Woodhouse
2010-08-12 1:21 ` David Woodhouse
2010-08-12 2:43 ` Marek Vasut [this message]
2010-08-12 2:43 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008120443.24749.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.