From: Joel Becker <Joel.Becker@oracle.com>
To: Julia Lawall <julia@diku.dk>
Cc: Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Sunil Mushran <sunil.mushran@oracle.com>
Subject: Re: [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of
Date: Thu, 12 Aug 2010 09:31:41 +0000 [thread overview]
Message-ID: <20100812093141.GA6561@mail.oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1008120735200.16027@ask.diku.dk>
On Thu, Aug 12, 2010 at 07:46:13AM +0200, Julia Lawall wrote:
> This seems a bit ugly to me, since it exposes the implementation of the
> list abstraction. What about the following:
Actually, we're going to go back to the original list_for_each()
and list_entry() version. It's a well understood idiom.
We're also going to re-audit the rest of the patch that changed
list_for_each() to list_for_each_entry(), just in case we missed another
semantic error.
Joel
--
Life's Little Instruction Book #30
"Never buy a house without a fireplace."
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Julia Lawall <julia@diku.dk>
Cc: Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Sunil Mushran <sunil.mushran@oracle.com>
Subject: [Ocfs2-devel] [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor
Date: Thu, 12 Aug 2010 02:31:41 -0700 [thread overview]
Message-ID: <20100812093141.GA6561@mail.oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1008120735200.16027@ask.diku.dk>
On Thu, Aug 12, 2010 at 07:46:13AM +0200, Julia Lawall wrote:
> This seems a bit ugly to me, since it exposes the implementation of the
> list abstraction. What about the following:
Actually, we're going to go back to the original list_for_each()
and list_entry() version. It's a well understood idiom.
We're also going to re-audit the rest of the patch that changed
list_for_each() to list_for_each_entry(), just in case we missed another
semantic error.
Joel
--
Life's Little Instruction Book #30
"Never buy a house without a fireplace."
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Julia Lawall <julia@diku.dk>
Cc: Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Sunil Mushran <sunil.mushran@oracle.com>
Subject: Re: [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor
Date: Thu, 12 Aug 2010 02:31:41 -0700 [thread overview]
Message-ID: <20100812093141.GA6561@mail.oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1008120735200.16027@ask.diku.dk>
On Thu, Aug 12, 2010 at 07:46:13AM +0200, Julia Lawall wrote:
> This seems a bit ugly to me, since it exposes the implementation of the
> list abstraction. What about the following:
Actually, we're going to go back to the original list_for_each()
and list_entry() version. It's a well understood idiom.
We're also going to re-audit the rest of the patch that changed
list_for_each() to list_for_each_entry(), just in case we missed another
semantic error.
Joel
--
Life's Little Instruction Book #30
"Never buy a house without a fireplace."
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-08-12 9:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 9:09 [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry Julia Lawall
2010-08-07 9:09 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor Julia Lawall
2010-08-07 9:09 ` [Ocfs2-devel] " Julia Lawall
2010-08-12 0:03 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of Joel Becker
2010-08-12 0:03 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor Joel Becker
2010-08-12 0:03 ` [Ocfs2-devel] " Joel Becker
2010-08-12 5:46 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry Julia Lawall
2010-08-12 5:46 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor Julia Lawall
2010-08-12 5:46 ` [Ocfs2-devel] " Julia Lawall
2010-08-12 7:14 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of Dan Carpenter
2010-08-12 7:14 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor Dan Carpenter
2010-08-12 7:14 ` [Ocfs2-devel] " Dan Carpenter
2010-08-12 9:31 ` Joel Becker [this message]
2010-08-12 9:31 ` Joel Becker
2010-08-12 9:31 ` [Ocfs2-devel] " Joel Becker
2011-11-02 7:39 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of Dan Carpenter
2011-11-02 7:39 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor Dan Carpenter
2011-11-02 17:05 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry Sunil Mushran
2011-11-02 17:05 ` [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor Sunil Mushran
2011-11-02 17:05 ` [Ocfs2-devel] " Sunil Mushran
2011-11-17 8:43 ` [Ocfs2-devel] [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of Joel Becker
2011-11-17 8:43 ` [Ocfs2-devel] [PATCH 1/2] fs/ocfs2/dlm: Eliminate update of list_for_each_entry loop cursor Joel Becker
2011-11-17 8:43 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100812093141.GA6561@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sunil.mushran@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.