From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: jack@suse.cz, hch@lst.de, nickpiggin@yahoo.com.au
Subject: + lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged.patch added to -mm tree
Date: Thu, 12 Aug 2010 15:38:47 -0700 [thread overview]
Message-ID: <201008122238.o7CMclxQ016748@imap1.linux-foundation.org> (raw)
The patch titled
lib/radix-tree.c: fix overflow in radix_tree_range_tag_if_tagged()
has been added to the -mm tree. Its filename is
lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: lib/radix-tree.c: fix overflow in radix_tree_range_tag_if_tagged()
From: Jan Kara <jack@suse.cz>
When radix_tree_maxindex() is ~0UL, it can happen that scanning
overflows index and tree traversal code goes astray reading memory
until it hits unreadable memory. Check for overflow and exit in
that case.
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/radix-tree.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN lib/radix-tree.c~lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged lib/radix-tree.c
--- a/lib/radix-tree.c~lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged
+++ a/lib/radix-tree.c
@@ -675,7 +675,8 @@ unsigned long radix_tree_range_tag_if_ta
next:
/* Go to next item at level determined by 'shift' */
index = ((index >> shift) + 1) << shift;
- if (index > last_index)
+ /* Overflow can happen when last_index is ~0UL... */
+ if (index > last_index || !index)
break;
if (tagged >= nr_to_tag)
break;
_
Patches currently in -mm which might be from jack@suse.cz are
origin.patch
lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged.patch
aio-do-not-return-erestartsys-and-friends-from-aio.patch
reiser4.patch
reply other threads:[~2010-08-12 22:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008122238.o7CMclxQ016748@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.