All of lore.kernel.org
 help / color / mirror / Atom feed
* + lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged.patch added to -mm tree
@ 2010-08-12 22:38 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-08-12 22:38 UTC (permalink / raw)
  To: mm-commits; +Cc: jack, hch, nickpiggin


The patch titled
     lib/radix-tree.c: fix overflow in radix_tree_range_tag_if_tagged()
has been added to the -mm tree.  Its filename is
     lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: lib/radix-tree.c: fix overflow in radix_tree_range_tag_if_tagged()
From: Jan Kara <jack@suse.cz>

When radix_tree_maxindex() is ~0UL, it can happen that scanning
overflows index and tree traversal code goes astray reading memory
until it hits unreadable memory. Check for overflow and exit in
that case.

Signed-off-by: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/radix-tree.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN lib/radix-tree.c~lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged lib/radix-tree.c
--- a/lib/radix-tree.c~lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged
+++ a/lib/radix-tree.c
@@ -675,7 +675,8 @@ unsigned long radix_tree_range_tag_if_ta
 next:
 		/* Go to next item at level determined by 'shift' */
 		index = ((index >> shift) + 1) << shift;
-		if (index > last_index)
+		/* Overflow can happen when last_index is ~0UL... */
+		if (index > last_index || !index)
 			break;
 		if (tagged >= nr_to_tag)
 			break;
_

Patches currently in -mm which might be from jack@suse.cz are

origin.patch
lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged.patch
aio-do-not-return-erestartsys-and-friends-from-aio.patch
reiser4.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-08-12 22:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-12 22:38 + lib-radix-treec-fix-overflow-in-radix_tree_range_tag_if_tagged.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.