From: Dan Carpenter <error27@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>,
Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 15/16] drivers/platform/x86: Use available error codes
Date: Mon, 16 Aug 2010 18:13:06 +0000 [thread overview]
Message-ID: <20100816181305.GD645@bicker> (raw)
In-Reply-To: <Pine.LNX.4.64.1008161828350.19313@ask.diku.dk>
On Mon, Aug 16, 2010 at 06:28:52PM +0200, Julia Lawall wrote:
> ---
> This changes the semantics and has not been tested. In each case, error is
> also assigned to the result of a function call. Perhpas that should be
> changed to result as well, and error should be eliminated.
>
Yep. That should be changed to result as well.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>,
Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 15/16] drivers/platform/x86: Use available error codes
Date: Mon, 16 Aug 2010 20:13:06 +0200 [thread overview]
Message-ID: <20100816181305.GD645@bicker> (raw)
In-Reply-To: <Pine.LNX.4.64.1008161828350.19313@ask.diku.dk>
On Mon, Aug 16, 2010 at 06:28:52PM +0200, Julia Lawall wrote:
> ---
> This changes the semantics and has not been tested. In each case, error is
> also assigned to the result of a function call. Perhpas that should be
> changed to result as well, and error should be eliminated.
>
Yep. That should be changed to result as well.
regards,
dan carpenter
next prev parent reply other threads:[~2010-08-16 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 16:28 [PATCH 15/16] drivers/platform/x86: Use available error codes Julia Lawall
2010-08-16 16:28 ` Julia Lawall
2010-08-16 17:11 ` Jonathan Woithe
2010-08-16 17:23 ` Jonathan Woithe
2010-08-16 17:11 ` Jonathan Woithe
2010-08-16 20:43 ` Julia Lawall
2010-08-16 20:43 ` Julia Lawall
2010-08-16 18:13 ` Dan Carpenter [this message]
2010-08-16 18:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816181305.GD645@bicker \
--to=error27@gmail.com \
--cc=julia@diku.dk \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.