From: Dan Carpenter <error27@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>,
Anirban Chakraborty <anirban.chakraborty@qlogic.com>,
linux-driver@qlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 16/16] drivers/net/qlcnic: Use available error codes
Date: Mon, 16 Aug 2010 18:35:40 +0000 [thread overview]
Message-ID: <20100816183540.GE645@bicker> (raw)
In-Reply-To: <Pine.LNX.4.64.1008161828520.19313@ask.diku.dk>
On Mon, Aug 16, 2010 at 06:29:13PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The error code is stored in the variable err, but it is the variable ret
> that is returned instead. So store the error code in ret. Err is then
> useless.
Could you redo this for the latest git? (Sorry, I recently made the
problem slightly worse by adding another "err = -ENOMEM;")...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>,
Anirban Chakraborty <anirban.chakraborty@qlogic.com>,
linux-driver@qlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 16/16] drivers/net/qlcnic: Use available error codes
Date: Mon, 16 Aug 2010 20:35:40 +0200 [thread overview]
Message-ID: <20100816183540.GE645@bicker> (raw)
In-Reply-To: <Pine.LNX.4.64.1008161828520.19313@ask.diku.dk>
On Mon, Aug 16, 2010 at 06:29:13PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The error code is stored in the variable err, but it is the variable ret
> that is returned instead. So store the error code in ret. Err is then
> useless.
Could you redo this for the latest git? (Sorry, I recently made the
problem slightly worse by adding another "err = -ENOMEM;")...
regards,
dan carpenter
next prev parent reply other threads:[~2010-08-16 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 16:29 [PATCH 16/16] drivers/net/qlcnic: Use available error codes Julia Lawall
2010-08-16 16:29 ` Julia Lawall
2010-08-16 16:29 ` Julia Lawall
2010-08-16 18:35 ` Dan Carpenter [this message]
2010-08-16 18:35 ` Dan Carpenter
2010-08-16 19:05 ` Julia Lawall
2010-08-16 19:05 ` Julia Lawall
2010-08-16 20:23 ` Julia Lawall
2010-08-16 20:23 ` Julia Lawall
2010-08-18 21:28 ` David Miller
2010-08-18 21:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816183540.GE645@bicker \
--to=error27@gmail.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.