From: Ralf Baechle <ralf@linux-mips.org>
To: Julia Lawall <julia@diku.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 8/16] net/ax25: Use available error codes
Date: Mon, 16 Aug 2010 19:23:50 +0000 [thread overview]
Message-ID: <20100816192350.GA10921@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1008161826390.19313@ask.diku.dk>
On Mon, Aug 16, 2010 at 06:26:57PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Error codes are stored in err, but the return value is always 0. Return
> err instead.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> local idexpression x;
> constant C;
> @@
>
> if (...) { ...
> x = -C
> ... when != x
> (
> return <+...x...+>;
> |
> return NULL;
> |
> return;
> |
> * return ...;
> )
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> This changes the semantics and has not been tested.
It restores the semantics to what they should be and used to be. This
probably happened during the introduction of proper refcounting and
locking into the AX.25 stack. Looks fine to me.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Julia Lawall <julia@diku.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-hams@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 8/16] net/ax25: Use available error codes
Date: Mon, 16 Aug 2010 20:23:50 +0100 [thread overview]
Message-ID: <20100816192350.GA10921@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1008161826390.19313@ask.diku.dk>
On Mon, Aug 16, 2010 at 06:26:57PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Error codes are stored in err, but the return value is always 0. Return
> err instead.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> local idexpression x;
> constant C;
> @@
>
> if (...) { ...
> x = -C
> ... when != x
> (
> return <+...x...+>;
> |
> return NULL;
> |
> return;
> |
> * return ...;
> )
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> This changes the semantics and has not been tested.
It restores the semantics to what they should be and used to be. This
probably happened during the introduction of proper refcounting and
locking into the AX.25 stack. Looks fine to me.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
next prev parent reply other threads:[~2010-08-16 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 16:26 [PATCH 8/16] net/ax25: Use available error codes Julia Lawall
2010-08-16 16:26 ` Julia Lawall
2010-08-16 19:23 ` Ralf Baechle [this message]
2010-08-16 19:23 ` Ralf Baechle
2010-08-18 21:28 ` David Miller
2010-08-18 21:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816192350.GA10921@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=davem@davemloft.net \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.