Re: [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection

[Tony Lindgren <tony@atomide.com>]

* Robert Nelson <robertcnelson@gmail.com> [100816 17:29]:
> Due to the omap3530 ES3.0 Silicon being used on both the
> B5/B6 and C1/2/3 Beagle we can't use the cpu_is_omap34xx() 
> routines to differentiate the Beagle Boards.
> 
> However gpio pins 171,172,173 where setup for this prupose, so 
> lets use them.
> 
> Changes:
> for older U-Boot's, use omap_mux_init_gpio()
> keep Beagle Rev in board-omap3beagle.c
> 
> Tested on Beagle Revisions: B5, C2, C4, and xMA

Looks good, just one minor comment below.
 
> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> Cc: Jarkko Nikula <jhnikula@gmail.com>
> ---
>  arch/arm/mach-omap2/board-omap3beagle.c |   79 +++++++++++++++++++++++++++++++
>  1 files changed, 79 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 87969c7..01a288f 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -50,6 +50,84 @@
>  
>  #define NAND_BLOCK_SIZE		SZ_128K
>  
> +/*
> + * OMAP3 Beagle revision
> + * Run time detection of Beagle revision is done by reading GPIO.
> + * GPIO ID -
> + *	AXBX	= GPIO173, GPIO172, GPIO171: 1 1 1
> + *	C1_3	= GPIO173, GPIO172, GPIO171: 1 1 0
> + *	C4	= GPIO173, GPIO172, GPIO171: 1 0 1
> + *	XM	= GPIO173, GPIO172, GPIO171: 0 0 0
> + */
> +enum {
> +	OMAP3BEAGLE_BOARD_AXBX = 0,
> +	OMAP3BEAGLE_BOARD_C1_3,
> +	OMAP3BEAGLE_BOARD_C4,
> +	OMAP3BEAGLE_BOARD_XM,
> +};
> +
> +static u8 omap3_beagle_version;
> +
> +u8 get_omap3_beagle_rev(void)
> +{
> +	return omap3_beagle_version;
> +}

Please make this static u8 get_omap3_beagle_rev().

Regards,

Tony