From: Jarkko Nikula <jhnikula@gmail.com>
To: Robert Nelson <robertcnelson@gmail.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection
Date: Wed, 18 Aug 2010 09:34:27 +0300 [thread overview]
Message-ID: <20100818093427.10c8770a.jhnikula@gmail.com> (raw)
In-Reply-To: <AANLkTinrJTCvorB0+LrFXmiChhZbbJZXeovmU3uWXYFw@mail.gmail.com>
On Tue, 17 Aug 2010 15:10:35 -0500
Robert Nelson <robertcnelson@gmail.com> wrote:
> Do you have any preference if the gpio allocation fails? Right now
> it'll just halts, we could just return as Cx based board.. Which would
> be the route the current kernel would take without this patch...
>
I think current code printing the error and letting the revision to be
zero or undefined is just fine. It's easier to debug if we let system
to continue booting instead of halting at early stage as there is no
any fatal risk with mmc gpio_wp if we cannot determine the revision.
--
Jarkko
next prev parent reply other threads:[~2010-08-18 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 14:36 [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection Robert Nelson
2010-08-16 14:36 ` [PATCH v4 2/3] ARM: OMAP: Beagle: only Cx boards use pin 23 for write protect Robert Nelson
2010-08-16 14:36 ` [PATCH v4 3/3] ARM: OMAP: Beagle: no gpio_wp pin connection on xM Robert Nelson
2010-08-17 5:48 ` [PATCH v4 1/3] ARM: OMAP: Beagle: revision detection Jarkko Nikula
2010-08-17 20:10 ` Robert Nelson
2010-08-18 6:34 ` Jarkko Nikula [this message]
2010-08-17 6:10 ` Tony Lindgren
2010-08-17 20:11 ` Robert Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818093427.10c8770a.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.