From: Dan Carpenter <error27@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [patch] pata_winbond: fix module init
Date: Tue, 17 Aug 2010 06:29:40 +0000 [thread overview]
Message-ID: <20100817062830.GF645@bicker> (raw)
In-Reply-To: <201008162123.03208.bzolnier@gmail.com>
On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Dan,
>
> On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
> > winbond_init_one() returns 0 on success and an error code on failure.
> > In the original code, we always just released the regions and return
> > -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
> > Winbond support".
>
> You might like to pick up
>
> http://patchwork.ozlabs.org/patch/39358/
>
> instead..
>
I don't have the hardware, but yes, probably it's better to replace this
driver since it has never been able to load.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [patch] pata_winbond: fix module init
Date: Tue, 17 Aug 2010 08:29:40 +0200 [thread overview]
Message-ID: <20100817062830.GF645@bicker> (raw)
In-Reply-To: <201008162123.03208.bzolnier@gmail.com>
On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Dan,
>
> On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
> > winbond_init_one() returns 0 on success and an error code on failure.
> > In the original code, we always just released the regions and return
> > -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
> > Winbond support".
>
> You might like to pick up
>
> http://patchwork.ozlabs.org/patch/39358/
>
> instead..
>
I don't have the hardware, but yes, probably it's better to replace this
driver since it has never been able to load.
regards,
dan carpenter
next prev parent reply other threads:[~2010-08-17 6:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 15:27 [patch] pata_winbond: fix module init Dan Carpenter
2010-08-03 15:27 ` Dan Carpenter
2010-08-16 19:23 ` Bartlomiej Zolnierkiewicz
2010-08-16 19:23 ` Bartlomiej Zolnierkiewicz
2010-08-17 6:29 ` Dan Carpenter [this message]
2010-08-17 6:29 ` Dan Carpenter
2010-08-17 9:52 ` Alan Cox
2010-08-17 10:07 ` Alan Cox
2010-08-17 17:39 ` Jeff Garzik
2010-08-17 17:39 ` Jeff Garzik
2010-08-17 21:52 ` Jeff Garzik
2010-08-17 21:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817062830.GF645@bicker \
--to=error27@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.