All of lore.kernel.org
 help / color / mirror / Atom feed
* MMC breakage
@ 2010-08-17 13:54 Russell King
  2010-08-17 15:21 ` Chris Ball
  0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2010-08-17 13:54 UTC (permalink / raw)
  To: Maxim Levitsky, Andrew Morton; +Cc: linux-mmc

I get the following build error:

	drivers/built-in.o: In function `mmc_alloc_host':
	mmci.c:(.text+0x80c44): undefined reference to `mmc_pm_notify'

Seems to be down to 4c2ef25fe.  The commit claims to fix the CONFIG_PM=n
build, but it seems not to as mmc_pm_notify() is within an #ifdef CONFIG_PM
block but the initialization isn't.

akpm - do you still have your "fix CONFIG_PM=n" changes for this patch?

-- 
Russell King

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: MMC breakage
  2010-08-17 13:54 MMC breakage Russell King
@ 2010-08-17 15:21 ` Chris Ball
  2010-08-17 16:31   ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Ball @ 2010-08-17 15:21 UTC (permalink / raw)
  To: Russell King; +Cc: Maxim Levitsky, Andrew Morton, linux-mmc

Hi Russell,

On Tue, Aug 17, 2010 at 02:54:56PM +0100, Russell King wrote:
> I get the following build error:
> 
> 	drivers/built-in.o: In function `mmc_alloc_host':
> 	mmci.c:(.text+0x80c44): undefined reference to `mmc_pm_notify'
> 
> Seems to be down to 4c2ef25fe.  The commit claims to fix the CONFIG_PM=n
> build, but it seems not to as mmc_pm_notify() is within an #ifdef CONFIG_PM
> block but the initialization isn't.

Patches have been sent to akpm to fix this already; see
  http://lkml.org/lkml/2010/8/12/207
  http://article.gmane.org/gmane.linux.kernel/1022716

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>
One Laptop Per Child

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: MMC breakage
  2010-08-17 15:21 ` Chris Ball
@ 2010-08-17 16:31   ` Andrew Morton
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2010-08-17 16:31 UTC (permalink / raw)
  To: Chris Ball; +Cc: Russell King, Maxim Levitsky, linux-mmc

On Tue, 17 Aug 2010 16:21:32 +0100 Chris Ball <cjb@laptop.org> wrote:

> Hi Russell,
> 
> On Tue, Aug 17, 2010 at 02:54:56PM +0100, Russell King wrote:
> > I get the following build error:
> > 
> > 	drivers/built-in.o: In function `mmc_alloc_host':
> > 	mmci.c:(.text+0x80c44): undefined reference to `mmc_pm_notify'
> > 
> > Seems to be down to 4c2ef25fe.  The commit claims to fix the CONFIG_PM=n
> > build, but it seems not to as mmc_pm_notify() is within an #ifdef CONFIG_PM
> > block but the initialization isn't.
> 
> Patches have been sent to akpm to fix this already; see
>   http://lkml.org/lkml/2010/8/12/207
>   http://article.gmane.org/gmane.linux.kernel/1022716
> 

yup.  I'm lying on a beach at present.  I expect I'll get onto these
later in the week.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-17 16:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-17 13:54 MMC breakage Russell King
2010-08-17 15:21 ` Chris Ball
2010-08-17 16:31   ` Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.