From: Dan Carpenter <error27@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ether1: Use net_device_stats from struct net_device
Date: Tue, 17 Aug 2010 18:32:05 +0000 [thread overview]
Message-ID: <20100817183205.GH645@bicker> (raw)
In-Reply-To: <1282061719-19645-1-git-send-email-tklauser@distanz.ch>
On Tue, Aug 17, 2010 at 06:15:19PM +0200, Tobias Klauser wrote:
> struct net_device has its own struct net_device_stats member, so use
> this one instead of a private copy in the ether1_priv struct.
>
You missed one in ether1_open().
memset (&priv(dev)->stats, 0, sizeof (struct net_device_stats));
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: error27@gmail.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ether1: Use net_device_stats from struct net_device
Date: Tue, 17 Aug 2010 20:32:05 +0200 [thread overview]
Message-ID: <20100817183205.GH645@bicker> (raw)
In-Reply-To: <1282061719-19645-1-git-send-email-tklauser@distanz.ch>
On Tue, Aug 17, 2010 at 06:15:19PM +0200, Tobias Klauser wrote:
> struct net_device has its own struct net_device_stats member, so use
> this one instead of a private copy in the ether1_priv struct.
>
You missed one in ether1_open().
memset (&priv(dev)->stats, 0, sizeof (struct net_device_stats));
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Russell King <linux@arm.linux.org.uk>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ether1: Use net_device_stats from struct net_device
Date: Tue, 17 Aug 2010 20:32:05 +0200 [thread overview]
Message-ID: <20100817183205.GH645@bicker> (raw)
In-Reply-To: <1282061719-19645-1-git-send-email-tklauser@distanz.ch>
On Tue, Aug 17, 2010 at 06:15:19PM +0200, Tobias Klauser wrote:
> struct net_device has its own struct net_device_stats member, so use
> this one instead of a private copy in the ether1_priv struct.
>
You missed one in ether1_open().
memset (&priv(dev)->stats, 0, sizeof (struct net_device_stats));
regards,
dan carpenter
next prev parent reply other threads:[~2010-08-17 18:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 16:15 [PATCH] ether1: Use net_device_stats from struct net_device Tobias Klauser
2010-08-17 16:15 ` Tobias Klauser
2010-08-17 16:15 ` Tobias Klauser
2010-08-17 18:32 ` Dan Carpenter [this message]
2010-08-17 18:32 ` Dan Carpenter
2010-08-17 18:32 ` Dan Carpenter
2010-08-17 18:34 ` Tobias Klauser
2010-08-17 18:34 ` Tobias Klauser
2010-08-17 18:34 ` Tobias Klauser
2010-08-18 7:04 ` [PATCH v2] " Tobias Klauser
2010-08-18 7:04 ` Tobias Klauser
2010-08-18 7:04 ` Tobias Klauser
2010-08-18 8:13 ` Russell King - ARM Linux
2010-08-18 8:13 ` Russell King - ARM Linux
2010-08-18 8:13 ` Russell King - ARM Linux
2010-08-18 8:27 ` Eric Dumazet
2010-08-18 8:27 ` Eric Dumazet
2010-08-18 8:27 ` Eric Dumazet
2010-08-18 8:33 ` Tobias Klauser
2010-08-18 8:33 ` Tobias Klauser
2010-08-18 8:33 ` Tobias Klauser
2010-08-18 15:33 ` Stephen Hemminger
2010-08-18 15:33 ` Stephen Hemminger
2010-08-18 15:33 ` Stephen Hemminger
2010-08-18 20:10 ` David Miller
2010-08-18 20:10 ` David Miller
2010-08-18 20:10 ` David Miller
2010-08-18 20:44 ` [PATCH net-next-2.6] atm: remove a net_device_stats clear Eric Dumazet
2010-08-18 20:44 ` Eric Dumazet
2010-08-18 20:44 ` Eric Dumazet
2010-08-19 7:15 ` David Miller
2010-08-19 7:15 ` David Miller
2010-08-19 7:15 ` David Miller
2010-08-19 6:14 ` [PATCH v2] ether1: Use net_device_stats from struct net_device Tobias Klauser
2010-08-19 6:14 ` Tobias Klauser
2010-08-19 6:14 ` Tobias Klauser
2010-08-18 8:45 ` [PATCH v3] " Tobias Klauser
2010-08-18 8:45 ` Tobias Klauser
2010-08-18 8:45 ` Tobias Klauser
2010-08-19 6:15 ` [PATCH v4] " Tobias Klauser
2010-08-19 6:15 ` Tobias Klauser
2010-08-19 6:15 ` Tobias Klauser
2010-08-19 7:12 ` David Miller
2010-08-19 7:12 ` David Miller
2010-08-19 7:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100817183205.GH645@bicker \
--to=error27@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.