All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Klauser <tklauser@distanz.ch>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ether3: Use net_device_stats from struct net_device
Date: Tue, 17 Aug 2010 18:53:56 +0000	[thread overview]
Message-ID: <20100817185356.GG15670@distanz.ch> (raw)
In-Reply-To: <20100817183551.GI645@bicker>

On 2010-08-17 at 20:35:52 +0200, Dan Carpenter <error27@gmail.com> wrote:
> On Tue, Aug 17, 2010 at 06:15:33PM +0200, Tobias Klauser wrote:
> > struct net_device has its own struct net_device_stats member, so use
> > this one instead of a private copy in the ether1_priv struct.
> > 
> 
> Two were missed, one from ether3_init_for_open()
> 
> 	memset(&priv(dev)->stats, 0, sizeof(struct net_device_stats));
> 
> and another from ether3_rx().
> 
> 	struct net_device_stats *stats = &priv(dev)->stats;

Thanks a lot again. I'll send an updated patch. Please disregard this
one.

(I wasn't able to cross-compile-test the patch here, otherwise these
would hopefully have been caught by the compiler).

  Tobias

WARNING: multiple messages have this Message-ID (diff)
From: tklauser@distanz.ch (Tobias Klauser)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ether3: Use net_device_stats from struct net_device
Date: Tue, 17 Aug 2010 20:53:56 +0200	[thread overview]
Message-ID: <20100817185356.GG15670@distanz.ch> (raw)
In-Reply-To: <20100817183551.GI645@bicker>

On 2010-08-17 at 20:35:52 +0200, Dan Carpenter <error27@gmail.com> wrote:
> On Tue, Aug 17, 2010 at 06:15:33PM +0200, Tobias Klauser wrote:
> > struct net_device has its own struct net_device_stats member, so use
> > this one instead of a private copy in the ether1_priv struct.
> > 
> 
> Two were missed, one from ether3_init_for_open()
> 
> 	memset(&priv(dev)->stats, 0, sizeof(struct net_device_stats));
> 
> and another from ether3_rx().
> 
> 	struct net_device_stats *stats = &priv(dev)->stats;

Thanks a lot again. I'll send an updated patch. Please disregard this
one.

(I wasn't able to cross-compile-test the patch here, otherwise these
would hopefully have been caught by the compiler).

  Tobias

WARNING: multiple messages have this Message-ID (diff)
From: Tobias Klauser <tklauser@distanz.ch>
To: Dan Carpenter <error27@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Russell King <linux@arm.linux.org.uk>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ether3: Use net_device_stats from struct net_device
Date: Tue, 17 Aug 2010 20:53:56 +0200	[thread overview]
Message-ID: <20100817185356.GG15670@distanz.ch> (raw)
In-Reply-To: <20100817183551.GI645@bicker>

On 2010-08-17 at 20:35:52 +0200, Dan Carpenter <error27@gmail.com> wrote:
> On Tue, Aug 17, 2010 at 06:15:33PM +0200, Tobias Klauser wrote:
> > struct net_device has its own struct net_device_stats member, so use
> > this one instead of a private copy in the ether1_priv struct.
> > 
> 
> Two were missed, one from ether3_init_for_open()
> 
> 	memset(&priv(dev)->stats, 0, sizeof(struct net_device_stats));
> 
> and another from ether3_rx().
> 
> 	struct net_device_stats *stats = &priv(dev)->stats;

Thanks a lot again. I'll send an updated patch. Please disregard this
one.

(I wasn't able to cross-compile-test the patch here, otherwise these
would hopefully have been caught by the compiler).

  Tobias

  reply	other threads:[~2010-08-17 18:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17 16:15 [PATCH] ether3: Use net_device_stats from struct net_device Tobias Klauser
2010-08-17 16:15 ` Tobias Klauser
2010-08-17 16:15 ` Tobias Klauser
2010-08-17 18:35 ` Dan Carpenter
2010-08-17 18:35   ` Dan Carpenter
2010-08-17 18:35   ` Dan Carpenter
2010-08-17 18:53   ` Tobias Klauser [this message]
2010-08-17 18:53     ` Tobias Klauser
2010-08-17 18:53     ` Tobias Klauser
2010-08-18  7:04 ` [PATCH v2] " Tobias Klauser
2010-08-18  7:04   ` Tobias Klauser
2010-08-18  7:04   ` Tobias Klauser
2010-08-18  8:46 ` [PATCH v3] " Tobias Klauser
2010-08-18  8:46   ` Tobias Klauser
2010-08-18  8:46   ` Tobias Klauser
2010-08-19  6:15 ` [PATCH v4] " Tobias Klauser
2010-08-19  6:15   ` Tobias Klauser
2010-08-19  6:15   ` Tobias Klauser
2010-08-19  7:13   ` David Miller
2010-08-19  7:13     ` David Miller
2010-08-19  7:13     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100817185356.GG15670@distanz.ch \
    --to=tklauser@distanz.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.