From: Andy Whitcroft <apw@canonical.com>
To: "Gopinath, Thara" <thara@ti.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Checkpatch false positive in 2.6.36-rc1.
Date: Wed, 18 Aug 2010 11:20:33 +0100 [thread overview]
Message-ID: <20100818102033.GP6193@shadowen.org> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB0324222271@dbde02.ent.ti.com>
On Wed, Aug 18, 2010 at 11:34:51AM +0530, Gopinath, Thara wrote:
> Hello Andy,
>
> The following is my patch.
>
> Index: linux-omap-pm/arch/arm/plat-omap/Kconfig
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/plat-omap/Kconfig
> +++ linux-omap-pm/arch/arm/plat-omap/Kconfig
> @@ -37,7 +37,7 @@ config OMAP_DEBUG_LEDS
>
> config OMAP_SMARTREFLEX
> bool "SmartReflex support"
> - depends on ARCH_OMAP3 && PM
> + depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM
> help
> Say Y if you want to enable SmartReflex.
>
>
> And the following is the check patch error I am getting
>
> WARNING: please write a paragraph that describes the config symbol fully
> #108: FILE: arch/arm/plat-omap/Kconfig:41:
> help
> total: 0 errors, 1 warnings, 67 lines checked
Yes that is a falsie. I think I have fixed it in my tree. Could you
test the version at the URL below and let me know if it works for you.
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw
next prev parent reply other threads:[~2010-08-18 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 6:04 Checkpatch false positive in 2.6.36-rc1 Gopinath, Thara
2010-08-18 10:20 ` Andy Whitcroft [this message]
2010-08-18 10:26 ` Gopinath, Thara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818102033.GP6193@shadowen.org \
--to=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thara@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.