Checkpatch false positive in 2.6.36-rc1.

Checkpatch false positive in 2.6.36-rc1.

[Gopinath, Thara]

Hello Andy,

The following is my patch.

Index: linux-omap-pm/arch/arm/plat-omap/Kconfig
===================================================================
--- linux-omap-pm.orig/arch/arm/plat-omap/Kconfig
+++ linux-omap-pm/arch/arm/plat-omap/Kconfig
@@ -37,7 +37,7 @@ config OMAP_DEBUG_LEDS

 config OMAP_SMARTREFLEX
        bool "SmartReflex support"
-       depends on ARCH_OMAP3 && PM
+       depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM
        help
          Say Y if you want to enable SmartReflex.


And the following is the check patch error I am getting

WARNING: please write a paragraph that describes the config symbol fully
#108: FILE: arch/arm/plat-omap/Kconfig:41:
        help

total: 0 errors, 1 warnings, 67 lines checked


I think this is a wrong warning as in the first place this is not a line
introduced or removed by my change. Also If I go to the relevant Kconfig
and take a look at this option it appears as below. So this means there
is an actual paragraph following the help.

config OMAP_SMARTREFLEX
        bool "SmartReflex support"
        depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM
        help
          Say Y if you want to enable SmartReflex.

          SmartReflex can perform continuous dynamic voltage
          scaling around the nominal operating point voltage
          according to silicon characteristics and operating
          conditions. Enabling SmartReflex reduces power
          consumption.

          Please note, that by default SmartReflex is only
          initialized. To enable the automatic voltage
          compensation for VDD1 and VDD2, user must write 1 to
          /debug/pm_debug/Smartreflex/SR<X>/autocomp,
          where X is 1 or 2 for OMAP3


Regards
Thara

Re: Checkpatch false positive in 2.6.36-rc1.

[Andy Whitcroft]

On Wed, Aug 18, 2010 at 11:34:51AM +0530, Gopinath, Thara wrote:
> Hello Andy,
> 
> The following is my patch.
> 
> Index: linux-omap-pm/arch/arm/plat-omap/Kconfig
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/plat-omap/Kconfig
> +++ linux-omap-pm/arch/arm/plat-omap/Kconfig
> @@ -37,7 +37,7 @@ config OMAP_DEBUG_LEDS
> 
>  config OMAP_SMARTREFLEX
>         bool "SmartReflex support"
> -       depends on ARCH_OMAP3 && PM
> +       depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM
>         help
>           Say Y if you want to enable SmartReflex.
> 
> 
> And the following is the check patch error I am getting
> 
> WARNING: please write a paragraph that describes the config symbol fully
> #108: FILE: arch/arm/plat-omap/Kconfig:41:
>         help
 
> total: 0 errors, 1 warnings, 67 lines checked

Yes that is a falsie.  I think I have fixed it in my tree.  Could you
test the version at the URL below and let me know if it works for you.

  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

-apw

RE: Checkpatch false positive in 2.6.36-rc1.

[Gopinath, Thara]

>>-----Original Message-----
>>From: Andy Whitcroft [mailto:apw@canonical.com]
>>Sent: Wednesday, August 18, 2010 3:51 PM
>>To: Gopinath, Thara
>>Cc: linux-kernel@vger.kernel.org
>>Subject: Re: Checkpatch false positive in 2.6.36-rc1.
>>
>>On Wed, Aug 18, 2010 at 11:34:51AM +0530, Gopinath, Thara wrote:
>>> Hello Andy,
>>>
>>> The following is my patch.
>>>
>>> Index: linux-omap-pm/arch/arm/plat-omap/Kconfig
>>> ===================================================================
>>> --- linux-omap-pm.orig/arch/arm/plat-omap/Kconfig
>>> +++ linux-omap-pm/arch/arm/plat-omap/Kconfig
>>> @@ -37,7 +37,7 @@ config OMAP_DEBUG_LEDS
>>>
>>>  config OMAP_SMARTREFLEX
>>>         bool "SmartReflex support"
>>> -       depends on ARCH_OMAP3 && PM
>>> +       depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM
>>>         help
>>>           Say Y if you want to enable SmartReflex.
>>>
>>>
>>> And the following is the check patch error I am getting
>>>
>>> WARNING: please write a paragraph that describes the config symbol fully
>>> #108: FILE: arch/arm/plat-omap/Kconfig:41:
>>>         help
>>
>>> total: 0 errors, 1 warnings, 67 lines checked
>>
>>Yes that is a falsie.  I think I have fixed it in my tree.  Could you
>>test the version at the URL below and let me know if it works for you.
>>
>>  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

Yep this works. It no longer gives me the warning.
Thanks.

Regards
Thara