All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurel32@debian.org>
To: grub-devel@gnu.org
Cc: 593467@bugs.debian.org, Colin Watson <cjwatson@ubuntu.com>
Subject: Re: Bug#593467: grub-pc: add support for root ext2/xfs on GNU/kFreeBSD
Date: Wed, 18 Aug 2010 17:46:24 +0200	[thread overview]
Message-ID: <20100818154623.GA7883@volta.aurel32.net> (raw)
In-Reply-To: <20100818141602.GC12396@riva.ucam.org>

On Wed, Aug 18, 2010 at 03:16:03PM +0100, Colin Watson wrote:
> On Wed, Aug 18, 2010 at 03:07:57PM +0200, Aurelien Jarno wrote:
> > Since GNU/kFreeBSD switch to grub as the default bootloader, it is 
> > almost possible to use an ext2 or xfs root filesystem. While there
> > is not a lot of interest in doing that, the patch to do it is quite
> > small. Could you please apply it in the next upload?
> 
> Sending upstream first.  Does this require copyright assignment?
> 

As I have been told on IRC, XFS support is only read-only, so there is
no point on adding root support for it yet. ext2 support works in read
write mode, and has been tested as root. Please find an updated patch 
below.

--- grub2-1.98+20100804.orig/util/grub.d/10_kfreebsd.in
+++ grub2-1.98+20100804/util/grub.d/10_kfreebsd.in
@@ -75,6 +75,14 @@
   fi
 
   case "${kfreebsd_fs}" in
+    ext2fs)
+      test -e "${module_dir}/ext2fs.ko"
+
+      printf '%s\n' "${prepare_module_dir_cache}"
+      cat << EOF
+	kfreebsd_module_elf	${module_dir_rel}/ext2fs.ko
+EOF
+    ;;
     zfs)
       test -e "${module_dir}/opensolaris.ko"
       test -e "${module_dir}/zfs.ko"
@@ -121,6 +129,7 @@
 
   case ${GRUB_FS} in
     ufs1 | ufs2)        kfreebsd_fs=ufs ;;
+    ext2)               kfreebsd_fs=ext2fs ;;
     *)                  kfreebsd_fs=${GRUB_FS} ;;
   esac
 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net


  reply	other threads:[~2010-08-18 15:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100818130757.88123.80791.reportbug@kfreebsd-amd64.aurel32.net>
2010-08-18 14:16 ` Bug#593467: grub-pc: add support for root ext2/xfs on GNU/kFreeBSD Colin Watson
2010-08-18 15:46   ` Aurelien Jarno [this message]
2010-08-20 10:09     ` Aurelien Jarno
2010-08-20 11:33   ` Robert Millan
2010-08-20 14:41     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100818154623.GA7883@volta.aurel32.net \
    --to=aurel32@debian.org \
    --cc=593467@bugs.debian.org \
    --cc=cjwatson@ubuntu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.