* + checkpatch-handle-casts-better-fixing-false-categorisation-of-as-binary.patch added to -mm tree
@ 2010-08-18 20:25 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-08-18 20:25 UTC (permalink / raw)
To: mm-commits; +Cc: apw, khali
The patch titled
checkpatch: handle casts better fixing false categorisation of : as binary
has been added to the -mm tree. Its filename is
checkpatch-handle-casts-better-fixing-false-categorisation-of-as-binary.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: checkpatch: handle casts better fixing false categorisation of : as binary
From: Andy Whitcroft <apw@canonical.com>
The following incantation is triggering categorisation of its colon (:) as
a binary form, which it is not:
return foo ? (s8)bar : baz;
Handle casts differently from types in the categoriser, allowing us to
better track (s8)bar as a value and not a declaration.
Reported-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
scripts/checkpatch.pl | 5 +++++
1 file changed, 5 insertions(+)
diff -puN scripts/checkpatch.pl~checkpatch-handle-casts-better-fixing-false-categorisation-of-as-binary scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-handle-casts-better-fixing-false-categorisation-of-as-binary
+++ a/scripts/checkpatch.pl
@@ -845,6 +845,11 @@ sub annotate_values {
$av_preprocessor = 0;
}
+ } elsif ($cur =~ /^(\(\s*$Type\s*)\)/) {
+ print "CAST($1)\n" if ($dbg_values > 1);
+ push(@av_paren_type, $type);
+ $type = 'C';
+
} elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
print "DECLARE($1)\n" if ($dbg_values > 1);
$type = 'T';
_
Patches currently in -mm which might be from apw@canonical.com are
checkpatch-fix-regressions-in-fix-handling-of-leading-spaces.patch
checkpatch-types-may-sit-on-a-line-on-their-own.patch
checkpatch-suggest-cleanpatch-and-cleanfile-when-appropriate.patch
checkpatch-ensure-we-do-not-collapse-bracketed-sections-into-constants.patch
checkpatch-handle-casts-better-fixing-false-categorisation-of-as-binary.patch
checkpatch-returning-errno-typically-should-be-negative.patch
checkpatch-add-check-for-space-after-struct-union-and-enum.patch
checkpatch-simplify-and-consolidate-missing-space-after-checks.patch
checkpatch-ensure-kconfig-help-checks-only-apply-when-we-are-adding-help.patch
checkpatch-check-for-incorrect-permissions.patch
checkpatch-add-additional-attribute-defines.patch
checkpatch-update-copyright-dates.patch
checkpatch-clean-up-structure-definition-macro-handline.patch
checkpatch-handle-export_symbol-for-device_attr-and-similar.patch
checkpatch-statement-block-context-analyser-should-look-at-sanitised-lines.patch
checkpatch-version-031.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-18 20:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18 20:25 + checkpatch-handle-casts-better-fixing-false-categorisation-of-as-binary.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.