From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: alsa-devel@alsa-project.org
Cc: alsa-devel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC/multi-component: fix au1x platform
Date: Thu, 19 Aug 2010 15:06:50 +0100 [thread overview]
Message-ID: <20100819140649.GA29395@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTikyZKhs6t8RRRd36KjW_Enb-+NGvUCraxEakHO5@mail.gmail.com>
On Thu, Aug 19, 2010 at 03:21:35PM +0200, Manuel Lauss wrote:
> Attached is a patch which fixes the Alchemy (au1x) audio platform
> in your "topic/multi-component" branch.
I would provide more detailed review but you've attached your patch as a
base64 encoded attachment rather than including it inline so my MUA
hasn't quoted it.
As far as your comments about multiple cards go this should now be
supported, though the fact that you're modifying the static data for the
DAI means that the aux1x drivers probably don't support this or only
support it in a limited fashion.
Your kobject_name() stuff looks pretty fishy - is there some reason for
not using dev_name()?
next prev parent reply other threads:[~2010-08-19 14:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 13:21 [PATCH] ASoC/multi-component: fix au1x platform Manuel Lauss
2010-08-19 14:06 ` Mark Brown [this message]
2010-08-19 14:30 ` Manuel Lauss
2010-08-19 14:35 ` Mark Brown
2010-08-19 14:39 ` Manuel Lauss
2010-08-19 14:48 ` Mark Brown
2010-08-19 14:58 ` Manuel Lauss
2010-08-19 15:17 ` Manuel Lauss
2010-08-19 15:52 ` Mark Brown
2010-08-19 15:59 ` Manuel Lauss
2010-08-19 16:06 ` Mark Brown
2010-08-19 16:21 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819140649.GA29395@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-devel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.