Re: [PATCH] vmstat : update zone stat threshold at onlining a cpu

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 20 Aug 2010 09:54:56 -0500 (CDT) Christoph Lameter <cl@linux-foundation.org> wrote:

> On Fri, 20 Aug 2010, KAMEZAWA Hiroyuki wrote:
> 
> >  1 file changed, 1 insertion(+)
> >
> > Index: mmotm-0811/mm/vmstat.c
> > ===================================================================
> > --- mmotm-0811.orig/mm/vmstat.c
> > +++ mmotm-0811/mm/vmstat.c
> > @@ -998,6 +998,7 @@ static int __cpuinit vmstat_cpuup_callba
> >  	switch (action) {
> >  	case CPU_ONLINE:
> >  	case CPU_ONLINE_FROZEN:
> > +		refresh_zone_stat_thresholds();
> >  		start_cpu_timer(cpu);
> >  		node_set_state(cpu_to_node(cpu), N_CPU);
> >  		break;
> 
> refresh_zone_stat_threshold must be run *after* the number of online cpus
> has been incremented. Does that occur before the callback?

It does. _cpu_up() calls __cpu_up() before calling cpu_notify().

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>