All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: David Rientjes <rientjes@google.com>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 4/6] jbd: remove dependency on __GFP_NOFAIL
Date: Mon, 23 Aug 2010 15:11:29 -0700	[thread overview]
Message-ID: <20100823151129.433875d9.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100823220347.GB3380@quack.suse.cz>

On Tue, 24 Aug 2010 00:03:47 +0200
Jan Kara <jack@suse.cz> wrote:

> So do
> you think that we should keep __GFP_NOFAIL as long as all callers are not
> able to handle allocation failures in more reasonable way?

The concept should be encapsulated in _some_ centralised fashion.

Helper functions would work as well as __GFP_NOFAIL, and will move any
runtime cost away from the good code and push it onto the bad code.


  reply	other threads:[~2010-08-23 22:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17  2:57 [patch 0/6] remove dependency on __GFP_NOFAIL David Rientjes
2010-08-17  2:57 ` [patch 1/6] md: " David Rientjes
2010-08-23 19:26   ` Andrew Morton
2010-08-23 19:35     ` David Rientjes
2010-08-23 19:51       ` Andrew Morton
2010-08-23 20:03         ` David Rientjes
2010-08-23 20:01       ` Andrew Morton
2010-08-23 20:08         ` David Rientjes
2010-08-23 20:23           ` Andrew Morton
2010-08-23 20:37             ` David Rientjes
2010-08-23 20:09         ` Pekka Enberg
2010-08-23 20:09           ` Pekka Enberg
2010-08-23 20:13           ` David Rientjes
2010-08-23 20:29             ` Pekka Enberg
2010-08-23 20:40               ` David Rientjes
2010-08-17  2:57 ` [patch 2/6] btrfs: " David Rientjes
2010-08-17  2:57 ` [patch 3/6] gfs2: " David Rientjes
2010-08-17  2:58 ` [patch 4/6] jbd: " David Rientjes
2010-08-17  9:51   ` Jan Kara
2010-08-17 17:48     ` David Rientjes
2010-08-23 19:28     ` Andrew Morton
2010-08-23 22:03       ` Jan Kara
2010-08-23 22:11         ` Andrew Morton [this message]
2010-08-23 22:21           ` Jan Kara
2010-08-23 22:22           ` David Rientjes
2010-08-17  2:58 ` [patch 5/6] ntfs: " David Rientjes
2010-08-17  2:58 ` [patch 6/6] reiserfs: " David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100823151129.433875d9.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.