From: Gleb Natapov <gleb@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, mingo@elte.hu,
a.p.zijlstra@chello.nl, tglx@linutronix.de, hpa@zytor.com,
riel@redhat.com, mtosatti@redhat.com
Subject: Re: [PATCH v5 03/12] Add async PF initialization to PV guest.
Date: Mon, 23 Aug 2010 19:10:45 +0300 [thread overview]
Message-ID: <20100823161045.GV10499@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1008231105230.8601@router.home>
On Mon, Aug 23, 2010 at 11:08:06AM -0500, Christoph Lameter wrote:
> On Mon, 23 Aug 2010, Gleb Natapov wrote:
>
> > > The guest will have to align this on a 64 byte boundary, should this
> > > be marked __aligned(64) here?
> > >
> > I do __aligned(64) when I declare variable of that type:
> >
> > static DEFINE_PER_CPU(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64);
>
> 64 byte boundary: You mean cacheline aligned? We have a special define for
> that.
>
> DEFINE_PER_CPU_SHARED_ALIGNED
IIRC I tried to use it and it does different alignment on 64/32 bit. The
alignment here is part of guest/host interface so it should be the same
on both.
--
Gleb.
WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, mingo@elte.hu,
a.p.zijlstra@chello.nl, tglx@linutronix.de, hpa@zytor.com,
riel@redhat.com, mtosatti@redhat.com
Subject: Re: [PATCH v5 03/12] Add async PF initialization to PV guest.
Date: Mon, 23 Aug 2010 19:10:45 +0300 [thread overview]
Message-ID: <20100823161045.GV10499@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1008231105230.8601@router.home>
On Mon, Aug 23, 2010 at 11:08:06AM -0500, Christoph Lameter wrote:
> On Mon, 23 Aug 2010, Gleb Natapov wrote:
>
> > > The guest will have to align this on a 64 byte boundary, should this
> > > be marked __aligned(64) here?
> > >
> > I do __aligned(64) when I declare variable of that type:
> >
> > static DEFINE_PER_CPU(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64);
>
> 64 byte boundary: You mean cacheline aligned? We have a special define for
> that.
>
> DEFINE_PER_CPU_SHARED_ALIGNED
IIRC I tried to use it and it does different alignment on 64/32 bit. The
alignment here is part of guest/host interface so it should be the same
on both.
--
Gleb.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-23 16:11 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 15:30 [PATCH v5 00/12] KVM: Add host swap event notifications for PV guest Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-07-19 15:30 ` [PATCH v5 01/12] Move kvm_smp_prepare_boot_cpu() from kvmclock.c to kvm.c Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-07-19 15:30 ` [PATCH v5 02/12] Add PV MSR to enable asynchronous page faults delivery Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-08-23 15:22 ` Avi Kivity
2010-08-23 15:22 ` Avi Kivity
2010-08-23 15:29 ` Gleb Natapov
2010-08-23 15:29 ` Gleb Natapov
2010-07-19 15:30 ` [PATCH v5 03/12] Add async PF initialization to PV guest Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-07-19 19:52 ` Rik van Riel
2010-07-19 19:52 ` Rik van Riel
2010-08-23 15:26 ` Avi Kivity
2010-08-23 15:26 ` Avi Kivity
2010-08-23 15:35 ` Gleb Natapov
2010-08-23 15:35 ` Gleb Natapov
2010-08-23 16:08 ` Christoph Lameter
2010-08-23 16:08 ` Christoph Lameter
2010-08-23 16:10 ` Gleb Natapov [this message]
2010-08-23 16:10 ` Gleb Natapov
2010-08-23 16:19 ` Avi Kivity
2010-08-23 16:19 ` Avi Kivity
2010-07-19 15:30 ` [PATCH v5 04/12] Provide special async page fault handler when async PF capability is detected Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-08-23 15:48 ` Avi Kivity
2010-08-23 15:48 ` Avi Kivity
2010-08-23 15:52 ` Rik van Riel
2010-08-23 15:52 ` Rik van Riel
2010-08-23 16:22 ` Avi Kivity
2010-08-23 16:22 ` Avi Kivity
2010-08-24 7:31 ` Gleb Natapov
2010-08-24 7:31 ` Gleb Natapov
2010-08-24 9:02 ` Avi Kivity
2010-08-24 9:02 ` Avi Kivity
2010-07-19 15:30 ` [PATCH v5 05/12] Export __get_user_pages_fast Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-07-19 15:30 ` [PATCH v5 06/12] Add get_user_pages() variant that fails if major fault is required Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-08-23 15:50 ` Avi Kivity
2010-08-23 15:50 ` Avi Kivity
2010-07-19 15:30 ` [PATCH v5 07/12] Maintain memslot version number Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-08-23 15:53 ` Avi Kivity
2010-08-23 15:53 ` Avi Kivity
2010-07-19 15:30 ` [PATCH v5 08/12] Inject asynchronous page fault into a guest if page is swapped out Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-08-23 16:17 ` Avi Kivity
2010-08-23 16:17 ` Avi Kivity
2010-08-24 7:52 ` Gleb Natapov
2010-08-24 7:52 ` Gleb Natapov
2010-08-24 9:04 ` Avi Kivity
2010-08-24 9:04 ` Avi Kivity
2010-08-24 12:28 ` Gleb Natapov
2010-08-24 12:28 ` Gleb Natapov
2010-08-24 12:33 ` Avi Kivity
2010-08-24 12:33 ` Avi Kivity
2010-07-19 15:30 ` [PATCH v5 09/12] Retry fault before vmentry Gleb Natapov
2010-07-19 15:30 ` Gleb Natapov
2010-08-24 9:25 ` Avi Kivity
2010-08-24 9:25 ` Avi Kivity
2010-08-24 9:33 ` Gleb Natapov
2010-08-24 9:33 ` Gleb Natapov
2010-08-24 9:38 ` Avi Kivity
2010-08-24 9:38 ` Avi Kivity
2010-07-19 15:31 ` [PATCH v5 10/12] Handle async PF in non preemptable context Gleb Natapov
2010-07-19 15:31 ` Gleb Natapov
2010-08-24 9:30 ` Avi Kivity
2010-08-24 9:30 ` Avi Kivity
2010-08-24 9:36 ` Gleb Natapov
2010-08-24 9:36 ` Gleb Natapov
2010-08-24 9:46 ` Avi Kivity
2010-08-24 9:46 ` Avi Kivity
2010-07-19 15:31 ` [PATCH v5 11/12] Let host know whether the guest can handle async PF in non-userspace context Gleb Natapov
2010-07-19 15:31 ` Gleb Natapov
2010-08-24 9:31 ` Avi Kivity
2010-08-24 9:31 ` Avi Kivity
2010-07-19 15:31 ` [PATCH v5 12/12] Send async PF when guest is not in userspace too Gleb Natapov
2010-07-19 15:31 ` Gleb Natapov
2010-08-24 9:36 ` Avi Kivity
2010-08-24 9:36 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823161045.GV10499@redhat.com \
--to=gleb@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=avi@redhat.com \
--cc=cl@linux.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.