* + blk-cgroup-fix-return-code-for-mkdir-calls.patch added to -mm tree
@ 2010-08-23 20:56 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-08-23 20:56 UTC (permalink / raw)
To: mm-commits; +Cc: ciju, axboe, dpshah, kamezawa.hiroyu, stable, vgoyal
The patch titled
blk-cgroup: fix return code for mkdir calls
has been added to the -mm tree. Its filename is
blk-cgroup-fix-return-code-for-mkdir-calls.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: blk-cgroup: fix return code for mkdir calls
From: Ciju Rajan K <ciju@linux.vnet.ibm.com>
If the cgroup hierarchy for blkio control groups is deeper than two
levels, kernel should not allow the creation of further levels. mkdir
system call does not except EINVAL as a return value. This patch replaces
EINVAL with more appropriate EPERM
Signed-off-by: Ciju Rajan K <ciju@linux.vnet.ibm.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Divyesh Shah <dpshah@google.com>
Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN block/blk-cgroup.c~blk-cgroup-fix-return-code-for-mkdir-calls block/blk-cgroup.c
--- a/block/blk-cgroup.c~blk-cgroup-fix-return-code-for-mkdir-calls
+++ a/block/blk-cgroup.c
@@ -966,7 +966,7 @@ blkiocg_create(struct cgroup_subsys *sub
/* Currently we do not support hierarchy deeper than two level (0,1) */
if (parent != cgroup->top_cgroup)
- return ERR_PTR(-EINVAL);
+ return ERR_PTR(-EPERM);
blkcg = kzalloc(sizeof(*blkcg), GFP_KERNEL);
if (!blkcg)
_
Patches currently in -mm which might be from ciju@linux.vnet.ibm.com are
blk-cgroup-fix-return-code-for-mkdir-calls.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-23 20:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-23 20:56 + blk-cgroup-fix-return-code-for-mkdir-calls.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.