* [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page
@ 2010-08-24 9:38 Olaf Hering
2010-08-24 17:05 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2010-08-24 9:38 UTC (permalink / raw)
To: Patrick Colp, xen-devel
Notify policy about a page that was just paged out to disk.
Up to now the code called the opposite function, which clears the
(xenpaging internal) reference bit, instead of setting it and marking
the page as gone.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
--- xen-unstable.hg-4.1.21976.orig/tools/xenpaging/xenpaging.c
+++ xen-unstable.hg-4.1.21976/tools/xenpaging/xenpaging.c
@@ -361,8 +361,8 @@ int xenpaging_evict_page(xc_interface *x
goto out;
}
- /* Notify policy of page being paged in */
- policy_notify_paged_in(paging->mem_event.domain_id, victim->gfn);
+ /* Notify policy of page being paged out */
+ policy_notify_paged_out(paging->mem_event.domain_id, victim->gfn);
out:
return ret;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page
2010-08-24 9:38 [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page Olaf Hering
@ 2010-08-24 17:05 ` Ian Jackson
2010-08-24 17:30 ` Patrick Colp
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2010-08-24 17:05 UTC (permalink / raw)
To: Olaf Hering; +Cc: Patrick Colp, xen-devel
Olaf Hering writes ("[Xen-devel] [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page"):
> Notify policy about a page that was just paged out to disk.
> Up to now the code called the opposite function, which clears the
> (xenpaging internal) reference bit, instead of setting it and marking
> the page as gone.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
This looks plausible but as I don't really understand the xenpaging
code I'd like an ack from Patrick. Patrick ?
Thanks,
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page
2010-08-24 17:05 ` Ian Jackson
@ 2010-08-24 17:30 ` Patrick Colp
0 siblings, 0 replies; 3+ messages in thread
From: Patrick Colp @ 2010-08-24 17:30 UTC (permalink / raw)
To: Ian Jackson; +Cc: Olaf Hering, xen-devel
Yes, this patch is correct.
Acked-by: Patrick Colp <pjcolp@cs.ubc.ca>
Patrick
On 24 August 2010 10:05, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page"):
>> Notify policy about a page that was just paged out to disk.
>> Up to now the code called the opposite function, which clears the
>> (xenpaging internal) reference bit, instead of setting it and marking
>> the page as gone.
>>
>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> This looks plausible but as I don't really understand the xenpaging
> code I'd like an ack from Patrick. Patrick ?
>
> Thanks,
> Ian.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-24 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-24 9:38 [PATCH] xenpaging: call pageout policy function in xenpaging_evict_page Olaf Hering
2010-08-24 17:05 ` Ian Jackson
2010-08-24 17:30 ` Patrick Colp
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.