* [patch] mtd/pcmciamtd: remove dead code
@ 2010-08-24 11:56 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-08-24 11:56 UTC (permalink / raw)
To: David Woodhouse
Cc: kernel-janitors, Dominik Brodowski, Magnus Damm, Alexander Kurz,
linux-mtd, Karsten Keil
This code isn't reachable. I looked through the git history and it
hasn't been reachable for years. Someone removed the label to silence
gcc's unused label warning but these few lines accidentally got left
behind.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/mtd/maps/pcmciamtd.c b/drivers/mtd/maps/pcmciamtd.c
index e9ca5ba..86c7468 100644
--- a/drivers/mtd/maps/pcmciamtd.c
+++ b/drivers/mtd/maps/pcmciamtd.c
@@ -654,10 +654,6 @@ static int pcmciamtd_config(struct pcmcia_device *link)
}
dev_info(&dev->p_dev->dev, "mtd%d: %s\n", mtd->index, mtd->name);
return 0;
-
- dev_err(&dev->p_dev->dev, "CS Error, exiting\n");
- pcmciamtd_release(link);
- return -ENODEV;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch] mtd/pcmciamtd: remove dead code
@ 2010-08-24 11:56 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-08-24 11:56 UTC (permalink / raw)
To: David Woodhouse
Cc: kernel-janitors, Dominik Brodowski, Magnus Damm, Alexander Kurz,
linux-mtd, Karsten Keil
This code isn't reachable. I looked through the git history and it
hasn't been reachable for years. Someone removed the label to silence
gcc's unused label warning but these few lines accidentally got left
behind.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/mtd/maps/pcmciamtd.c b/drivers/mtd/maps/pcmciamtd.c
index e9ca5ba..86c7468 100644
--- a/drivers/mtd/maps/pcmciamtd.c
+++ b/drivers/mtd/maps/pcmciamtd.c
@@ -654,10 +654,6 @@ static int pcmciamtd_config(struct pcmcia_device *link)
}
dev_info(&dev->p_dev->dev, "mtd%d: %s\n", mtd->index, mtd->name);
return 0;
-
- dev_err(&dev->p_dev->dev, "CS Error, exiting\n");
- pcmciamtd_release(link);
- return -ENODEV;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] mtd/pcmciamtd: remove dead code
2010-08-24 11:56 ` Dan Carpenter
@ 2010-08-29 19:15 ` Dominik Brodowski
-1 siblings, 0 replies; 6+ messages in thread
From: Dominik Brodowski @ 2010-08-29 19:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Woodhouse, kernel-janitors, Magnus Damm, Alexander Kurz,
linux-mtd, Karsten Keil
On Tue, Aug 24, 2010 at 01:56:27PM +0200, Dan Carpenter wrote:
> This code isn't reachable. I looked through the git history and it
> hasn't been reachable for years. Someone removed the label to silence
> gcc's unused label warning but these few lines accidentally got left
> behind.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks,
Dominik
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mtd/pcmciamtd: remove dead code
@ 2010-08-29 19:15 ` Dominik Brodowski
0 siblings, 0 replies; 6+ messages in thread
From: Dominik Brodowski @ 2010-08-29 19:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Woodhouse, kernel-janitors, Magnus Damm, Alexander Kurz,
linux-mtd, Karsten Keil
On Tue, Aug 24, 2010 at 01:56:27PM +0200, Dan Carpenter wrote:
> This code isn't reachable. I looked through the git history and it
> hasn't been reachable for years. Someone removed the label to silence
> gcc's unused label warning but these few lines accidentally got left
> behind.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks,
Dominik
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mtd/pcmciamtd: remove dead code
2010-08-24 11:56 ` Dan Carpenter
@ 2010-08-30 13:17 ` Artem Bityutskiy
-1 siblings, 0 replies; 6+ messages in thread
From: Artem Bityutskiy @ 2010-08-30 13:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Karsten Keil, kernel-janitors, Dominik Brodowski, Magnus Damm,
Alexander Kurz, linux-mtd, David Woodhouse
On Tue, 2010-08-24 at 13:56 +0200, Dan Carpenter wrote:
> This code isn't reachable. I looked through the git history and it
> hasn't been reachable for years. Someone removed the label to silence
> gcc's unused label warning but these few lines accidentally got left
> behind.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Pushed to l2-mtd-2.6.git / master, thanks.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] mtd/pcmciamtd: remove dead code
@ 2010-08-30 13:17 ` Artem Bityutskiy
0 siblings, 0 replies; 6+ messages in thread
From: Artem Bityutskiy @ 2010-08-30 13:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Karsten Keil, kernel-janitors, Dominik Brodowski, Magnus Damm,
Alexander Kurz, linux-mtd, David Woodhouse
On Tue, 2010-08-24 at 13:56 +0200, Dan Carpenter wrote:
> This code isn't reachable. I looked through the git history and it
> hasn't been reachable for years. Someone removed the label to silence
> gcc's unused label warning but these few lines accidentally got left
> behind.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Pushed to l2-mtd-2.6.git / master, thanks.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-30 13:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-24 11:56 [patch] mtd/pcmciamtd: remove dead code Dan Carpenter
2010-08-24 11:56 ` Dan Carpenter
2010-08-29 19:15 ` Dominik Brodowski
2010-08-29 19:15 ` Dominik Brodowski
2010-08-30 13:17 ` Artem Bityutskiy
2010-08-30 13:17 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.