From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: shijie8@gmail.com, bjorn.helgaas@hp.com, jbarnes@virtuousgeek.org
Subject: + kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource.patch added to -mm tree
Date: Tue, 24 Aug 2010 16:46:42 -0700 [thread overview]
Message-ID: <201008242346.o7ONkgAf023360@imap1.linux-foundation.org> (raw)
The patch titled
kernel/resource.c: handle reinsertion of an already-inserted resource
has been added to the -mm tree. Its filename is
kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: kernel/resource.c: handle reinsertion of an already-inserted resource
From: Huang Shijie <shijie8@gmail.com>
If the same resource is inserted to the resource tree (maybe not on
purpose), a dead loop will be created. In this situation, The kernel does
not report any warning or error :(
The command below will show a endless print.
#cat /proc/iomem
[akpm@linux-foundation.org: add WARN_ON()]
Signed-off-by: Huang Shijie <shijie8@gmail.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
kernel/resource.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN kernel/resource.c~kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource kernel/resource.c
--- a/kernel/resource.c~kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource
+++ a/kernel/resource.c
@@ -453,6 +453,8 @@ static struct resource * __insert_resour
if (first == parent)
return first;
+ if (WARN_ON(first == new)) /* duplicated insertion */
+ return first;
if ((first->start > new->start) || (first->end < new->end))
break;
_
Patches currently in -mm which might be from shijie8@gmail.com are
kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource.patch
reply other threads:[~2010-08-24 23:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008242346.o7ONkgAf023360@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.