All of lore.kernel.org
 help / color / mirror / Atom feed
* + kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource.patch added to -mm tree
@ 2010-08-24 23:46 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-08-24 23:46 UTC (permalink / raw)
  To: mm-commits; +Cc: shijie8, bjorn.helgaas, jbarnes


The patch titled
     kernel/resource.c: handle reinsertion of an already-inserted resource
has been added to the -mm tree.  Its filename is
     kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: kernel/resource.c: handle reinsertion of an already-inserted resource
From: Huang Shijie <shijie8@gmail.com>

If the same resource is inserted to the resource tree (maybe not on
purpose), a dead loop will be created.  In this situation, The kernel does
not report any warning or error :(

  The command below will show a endless print.
  #cat /proc/iomem

[akpm@linux-foundation.org: add WARN_ON()]
Signed-off-by: Huang Shijie <shijie8@gmail.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/resource.c |    2 ++
 1 file changed, 2 insertions(+)

diff -puN kernel/resource.c~kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource kernel/resource.c
--- a/kernel/resource.c~kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource
+++ a/kernel/resource.c
@@ -453,6 +453,8 @@ static struct resource * __insert_resour
 
 		if (first == parent)
 			return first;
+		if (WARN_ON(first == new))	/* duplicated insertion */
+			return first;
 
 		if ((first->start > new->start) || (first->end < new->end))
 			break;
_

Patches currently in -mm which might be from shijie8@gmail.com are

kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-08-24 23:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-24 23:46 + kernel-resourcec-handle-reinsertion-of-an-already-inserted-resource.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.