* + rocket-release_region-or-error-path.patch added to -mm tree
@ 2010-08-25 22:22 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-08-25 22:22 UTC (permalink / raw)
To: mm-commits; +Cc: error27
The patch titled
drivers/char/rocket.c: release_region or error path
has been added to the -mm tree. Its filename is
rocket-release_region-or-error-path.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: drivers/char/rocket.c: release_region or error path
From: Dan Carpenter <error27@gmail.com>
There was a release_region() missing on the error path.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/char/rocket.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff -puN drivers/char/rocket.c~rocket-release_region-or-error-path drivers/char/rocket.c
--- a/drivers/char/rocket.c~rocket-release_region-or-error-path
+++ a/drivers/char/rocket.c
@@ -2345,7 +2345,7 @@ static int __init rp_init(void)
ret = tty_register_driver(rocket_driver);
if (ret < 0) {
printk(KERN_ERR "Couldn't install tty RocketPort driver\n");
- goto err_tty;
+ goto err_controller;
}
#ifdef ROCKET_DEBUG_OPEN
@@ -2380,6 +2380,9 @@ static int __init rp_init(void)
return 0;
err_ttyu:
tty_unregister_driver(rocket_driver);
+err_controller:
+ if (controller)
+ release_region(controller, 4);
err_tty:
put_tty_driver(rocket_driver);
err:
_
Patches currently in -mm which might be from error27@gmail.com are
origin.patch
linux-next.patch
drivers-scsi-pm8001-pm8001_hwic-handle-allocation-failures.patch
rocket-release_region-or-error-path.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-25 22:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-25 22:22 + rocket-release_region-or-error-path.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.