All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Patrick Colp <pjcolp@cs.ubc.ca>
Cc: xen-devel@lists.xensource.com
Subject: Re: paged granttable entries
Date: Thu, 26 Aug 2010 16:50:24 +0200	[thread overview]
Message-ID: <20100826145024.GA7338@aepfle.de> (raw)
In-Reply-To: <20100826121355.GA6254@aepfle.de>


Patrick,

while looking for other usage of p2m_mem_paging_populate(), I found two
calls in __gnttab_copy(). They set the error gnttab_copy_t->status to
-ENOENT.
Should this better be something from the GNTST_* namespace? I did not
see a check for -ENOENT "on the other side".

At least the kernel drivers in SLES11 do only check for GNTST_okay and
GNTST_eagain and GNTST_bad_page.


And a quick search for op->status usage shows a mix of GNTST_* and
status != 0. While it may not make much difference, perhaps there should
be some translation between the granttable error namespace and other
namespaces.


Olaf

  reply	other threads:[~2010-08-26 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26 12:13 paged granttable entries Olaf Hering
2010-08-26 14:50 ` Olaf Hering [this message]
2010-08-26 18:17   ` Patrick Colp
2010-08-31 19:24     ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100826145024.GA7338@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=pjcolp@cs.ubc.ca \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.