* Fix bind_irq_vector() destination
@ 2010-08-26 9:14 Sheng Yang
2010-08-26 9:22 ` Keir Fraser
0 siblings, 1 reply; 4+ messages in thread
From: Sheng Yang @ 2010-08-26 9:14 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel@lists.xensource.com
[-- Attachment #1: Type: Text/Plain, Size: 887 bytes --]
The "mask" covered all online cpus in the "domain". It should be used as
destination later, instead of using "domain" directly.
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
--
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -86,14 +86,14 @@
cpus_and(mask, domain, cpu_online_map);
if (cpus_empty(mask))
return -EINVAL;
- if ((cfg->vector == vector) && cpus_equal(cfg->domain, domain))
+ if ((cfg->vector == vector) && cpus_equal(cfg->domain, mask))
return 0;
if (cfg->vector != IRQ_VECTOR_UNASSIGNED)
return -EBUSY;
for_each_cpu_mask(cpu, mask)
per_cpu(vector_irq, cpu)[vector] = irq;
cfg->vector = vector;
- cfg->domain = domain;
+ cfg->domain = mask;
irq_status[irq] = IRQ_USED;
if (IO_APIC_IRQ(irq))
irq_vector[irq] = vector;
[-- Attachment #2: binding_fix.patch --]
[-- Type: text/x-patch, Size: 704 bytes --]
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -86,14 +86,14 @@
cpus_and(mask, domain, cpu_online_map);
if (cpus_empty(mask))
return -EINVAL;
- if ((cfg->vector == vector) && cpus_equal(cfg->domain, domain))
+ if ((cfg->vector == vector) && cpus_equal(cfg->domain, mask))
return 0;
if (cfg->vector != IRQ_VECTOR_UNASSIGNED)
return -EBUSY;
for_each_cpu_mask(cpu, mask)
per_cpu(vector_irq, cpu)[vector] = irq;
cfg->vector = vector;
- cfg->domain = domain;
+ cfg->domain = mask;
irq_status[irq] = IRQ_USED;
if (IO_APIC_IRQ(irq))
irq_vector[irq] = vector;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Fix bind_irq_vector() destination
2010-08-26 9:14 Fix bind_irq_vector() destination Sheng Yang
@ 2010-08-26 9:22 ` Keir Fraser
2010-08-26 9:40 ` Sheng Yang
0 siblings, 1 reply; 4+ messages in thread
From: Keir Fraser @ 2010-08-26 9:22 UTC (permalink / raw)
To: Sheng Yang; +Cc: xen-devel@lists.xensource.com
By the way, could an IRQ's 'domain' be given a better name in Xen? We
already have a meaning for domain, and it makes the code very confusing! Can
we call it cpu_affinity or cpu_binding, or something a bit more meaningful
and distinguishable?
-- Keir
On 26/08/2010 10:14, "Sheng Yang" <sheng@linux.intel.com> wrote:
> The "mask" covered all online cpus in the "domain". It should be used as
> destination later, instead of using "domain" directly.
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
>
> --
> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -86,14 +86,14 @@
> cpus_and(mask, domain, cpu_online_map);
> if (cpus_empty(mask))
> return -EINVAL;
> - if ((cfg->vector == vector) && cpus_equal(cfg->domain, domain))
> + if ((cfg->vector == vector) && cpus_equal(cfg->domain, mask))
> return 0;
> if (cfg->vector != IRQ_VECTOR_UNASSIGNED)
> return -EBUSY;
> for_each_cpu_mask(cpu, mask)
> per_cpu(vector_irq, cpu)[vector] = irq;
> cfg->vector = vector;
> - cfg->domain = domain;
> + cfg->domain = mask;
> irq_status[irq] = IRQ_USED;
> if (IO_APIC_IRQ(irq))
> irq_vector[irq] = vector;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix bind_irq_vector() destination
2010-08-26 9:22 ` Keir Fraser
@ 2010-08-26 9:40 ` Sheng Yang
2010-08-26 10:18 ` Keir Fraser
0 siblings, 1 reply; 4+ messages in thread
From: Sheng Yang @ 2010-08-26 9:40 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel@lists.xensource.com
On Thursday 26 August 2010 17:22:29 Keir Fraser wrote:
> By the way, could an IRQ's 'domain' be given a better name in Xen? We
> already have a meaning for domain, and it makes the code very confusing!
> Can we call it cpu_affinity or cpu_binding, or something a bit more
> meaningful and distinguishable?
Or use cpu_mask directly? Would send an separate patch if you like, for whatever
name. :)
--
regards
Yang, Sheng
>
> -- Keir
>
> On 26/08/2010 10:14, "Sheng Yang" <sheng@linux.intel.com> wrote:
> > The "mask" covered all online cpus in the "domain". It should be used as
> > destination later, instead of using "domain" directly.
> >
> > Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> >
> > --
> > diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
> > --- a/xen/arch/x86/irq.c
> > +++ b/xen/arch/x86/irq.c
> > @@ -86,14 +86,14 @@
> >
> > cpus_and(mask, domain, cpu_online_map);
> > if (cpus_empty(mask))
> >
> > return -EINVAL;
> >
> > - if ((cfg->vector == vector) && cpus_equal(cfg->domain, domain))
> > + if ((cfg->vector == vector) && cpus_equal(cfg->domain, mask))
> >
> > return 0;
> >
> > if (cfg->vector != IRQ_VECTOR_UNASSIGNED)
> >
> > return -EBUSY;
> >
> > for_each_cpu_mask(cpu, mask)
> >
> > per_cpu(vector_irq, cpu)[vector] = irq;
> >
> > cfg->vector = vector;
> >
> > - cfg->domain = domain;
> > + cfg->domain = mask;
> >
> > irq_status[irq] = IRQ_USED;
> > if (IO_APIC_IRQ(irq))
> >
> > irq_vector[irq] = vector;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix bind_irq_vector() destination
2010-08-26 9:40 ` Sheng Yang
@ 2010-08-26 10:18 ` Keir Fraser
0 siblings, 0 replies; 4+ messages in thread
From: Keir Fraser @ 2010-08-26 10:18 UTC (permalink / raw)
To: Sheng Yang; +Cc: xen-devel@lists.xensource.com
On 26/08/2010 10:40, "Sheng Yang" <sheng@linux.intel.com> wrote:
> On Thursday 26 August 2010 17:22:29 Keir Fraser wrote:
>> By the way, could an IRQ's 'domain' be given a better name in Xen? We
>> already have a meaning for domain, and it makes the code very confusing!
>> Can we call it cpu_affinity or cpu_binding, or something a bit more
>> meaningful and distinguishable?
>
> Or use cpu_mask directly? Would send an separate patch if you like, for
> whatever
> name. :)
Yes, cpu_mask would be fine. I applied your other two patches now. So send a
patch against http://xenbits.xen.org/staging/xen-unstable.hg
Thanks,
Keir
> --
> regards
> Yang, Sheng
>
>>
>> -- Keir
>>
>> On 26/08/2010 10:14, "Sheng Yang" <sheng@linux.intel.com> wrote:
>>> The "mask" covered all online cpus in the "domain". It should be used as
>>> destination later, instead of using "domain" directly.
>>>
>>> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
>>>
>>> --
>>> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
>>> --- a/xen/arch/x86/irq.c
>>> +++ b/xen/arch/x86/irq.c
>>> @@ -86,14 +86,14 @@
>>>
>>> cpus_and(mask, domain, cpu_online_map);
>>> if (cpus_empty(mask))
>>>
>>> return -EINVAL;
>>>
>>> - if ((cfg->vector == vector) && cpus_equal(cfg->domain, domain))
>>> + if ((cfg->vector == vector) && cpus_equal(cfg->domain, mask))
>>>
>>> return 0;
>>>
>>> if (cfg->vector != IRQ_VECTOR_UNASSIGNED)
>>>
>>> return -EBUSY;
>>>
>>> for_each_cpu_mask(cpu, mask)
>>>
>>> per_cpu(vector_irq, cpu)[vector] = irq;
>>>
>>> cfg->vector = vector;
>>>
>>> - cfg->domain = domain;
>>> + cfg->domain = mask;
>>>
>>> irq_status[irq] = IRQ_USED;
>>> if (IO_APIC_IRQ(irq))
>>>
>>> irq_vector[irq] = vector;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-26 10:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-26 9:14 Fix bind_irq_vector() destination Sheng Yang
2010-08-26 9:22 ` Keir Fraser
2010-08-26 9:40 ` Sheng Yang
2010-08-26 10:18 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.