From: Andrew Morton <akpm@linux-foundation.org>
To: Chris Ball <cjb@laptop.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-kernel@vger.kernel.org,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH RESEND] initialise DMA engine before MMC
Date: Fri, 27 Aug 2010 13:02:33 -0700 [thread overview]
Message-ID: <20100827130233.893e7151.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100827194939.GJ23079@void.printf.net>
On Fri, 27 Aug 2010 20:49:39 +0100
Chris Ball <cjb@laptop.org> wrote:
> Hi,
>
> Andrew, mind taking this one?
>
> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST)
>
> To use DMA engine based DMA with MMC in a non-modular build, the DMA
> engine has to initialise before MMC.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> ---
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 91874e0..b713e75 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/
> obj-y += lguest/
> obj-$(CONFIG_CPU_FREQ) += cpufreq/
> obj-$(CONFIG_CPU_IDLE) += cpuidle/
> +obj-$(CONFIG_DMA_ENGINE) += dma/
> obj-$(CONFIG_MMC) += mmc/
> obj-$(CONFIG_MEMSTICK) += memstick/
> obj-$(CONFIG_NEW_LEDS) += leds/
> @@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/
> obj-$(CONFIG_SUPERH) += sh/
> obj-$(CONFIG_ARCH_SHMOBILE) += sh/
> obj-$(CONFIG_GENERIC_TIME) += clocksource/
> -obj-$(CONFIG_DMA_ENGINE) += dma/
> obj-$(CONFIG_DCA) += dca/
> obj-$(CONFIG_HID) += hid/
> obj-$(CONFIG_PPC_PS3) += ps3/
erk, doing this via link ordering isn't nice.
It would be better to express this dependency via initcall levels -
core_initcall() or something.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Chris Ball <cjb@laptop.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-kernel@vger.kernel.org,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH RESEND] initialise DMA engine before MMC
Date: Fri, 27 Aug 2010 20:02:33 +0000 [thread overview]
Message-ID: <20100827130233.893e7151.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100827194939.GJ23079@void.printf.net>
On Fri, 27 Aug 2010 20:49:39 +0100
Chris Ball <cjb@laptop.org> wrote:
> Hi,
>
> Andrew, mind taking this one?
>
> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Date: Mon, 7 Jun 2010 13:16:36 +0200 (CEST)
>
> To use DMA engine based DMA with MMC in a non-modular build, the DMA
> engine has to initialise before MMC.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> ---
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 91874e0..b713e75 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -92,6 +92,7 @@ obj-$(CONFIG_EISA) += eisa/
> obj-y += lguest/
> obj-$(CONFIG_CPU_FREQ) += cpufreq/
> obj-$(CONFIG_CPU_IDLE) += cpuidle/
> +obj-$(CONFIG_DMA_ENGINE) += dma/
> obj-$(CONFIG_MMC) += mmc/
> obj-$(CONFIG_MEMSTICK) += memstick/
> obj-$(CONFIG_NEW_LEDS) += leds/
> @@ -102,7 +103,6 @@ obj-$(CONFIG_CRYPTO) += crypto/
> obj-$(CONFIG_SUPERH) += sh/
> obj-$(CONFIG_ARCH_SHMOBILE) += sh/
> obj-$(CONFIG_GENERIC_TIME) += clocksource/
> -obj-$(CONFIG_DMA_ENGINE) += dma/
> obj-$(CONFIG_DCA) += dca/
> obj-$(CONFIG_HID) += hid/
> obj-$(CONFIG_PPC_PS3) += ps3/
erk, doing this via link ordering isn't nice.
It would be better to express this dependency via initcall levels -
core_initcall() or something.
next prev parent reply other threads:[~2010-08-27 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 11:16 [PATCH] initialise DMA engine before MMC Guennadi Liakhovetski
2010-06-07 11:16 ` Guennadi Liakhovetski
2010-06-21 4:40 ` Paul Mundt
2010-06-21 4:40 ` Paul Mundt
2010-06-22 23:34 ` Dan Williams
2010-06-22 23:34 ` Dan Williams
2010-06-23 6:47 ` Linus Walleij
2010-06-23 6:47 ` Linus Walleij
2010-08-27 19:49 ` [PATCH RESEND] " Chris Ball
2010-08-27 19:49 ` Chris Ball
2010-08-27 20:02 ` Andrew Morton [this message]
2010-08-27 20:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827130233.893e7151.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cjb@laptop.org \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.