From: Chris Ball <cjb@laptop.org>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Pierre Ossman <pierre@ossman.eu>,
Andrew Morton <akpm@linux-foundation.org>,
Matt Fleming <matt@console-pimps.org>,
Adrian Hunter <adrian.hunter@nokia.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Linus Walleij <linus.walleij@stericsson.com>,
Eric Miao <eric.y.miao@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Cliff Brake <cbrake@bec-systems.com>,
Jarkko Lavinen <jarkko.lavinen@nokia.com>,
Madhusudhan <madhu.cr@ti.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: move regulator handling to core
Date: Fri, 27 Aug 2010 20:03:06 +0100 [thread overview]
Message-ID: <20100827190306.GB20407@void.printf.net> (raw)
In-Reply-To: <1259844390-10541-1-git-send-email-daniel@caiaq.de>
Hi Daniel,
On Thu, Dec 03, 2009 at 01:46:30PM +0100, Daniel Mack wrote:
> At the moment, regulator operations are done from individual mmc host
> drivers. This is a problem because the regulators are not claimed
> exclusively but the mmc core enables and disables them according to the
> return value of regulator_is_enabled(). That can lead to a number of
> problems and warnings when regulators are shared among multiple
> consumers or if regulators are marked as 'always_on'.
>
> Fix this by moving the some logic to the core, and put the regulator
> reference to the mmc_host struct and let it do its own supply state
> tracking so that the reference counting in the regulator won't get
> confused.
Looks like this patch got dropped because of the missing modifications
to arch/arm/mach-omap2/mmc-twl4030.c. Are we still interested in the
patch otherwise, and can anyone help with that?
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: move regulator handling to core
Date: Fri, 27 Aug 2010 20:03:06 +0100 [thread overview]
Message-ID: <20100827190306.GB20407@void.printf.net> (raw)
In-Reply-To: <1259844390-10541-1-git-send-email-daniel@caiaq.de>
Hi Daniel,
On Thu, Dec 03, 2009 at 01:46:30PM +0100, Daniel Mack wrote:
> At the moment, regulator operations are done from individual mmc host
> drivers. This is a problem because the regulators are not claimed
> exclusively but the mmc core enables and disables them according to the
> return value of regulator_is_enabled(). That can lead to a number of
> problems and warnings when regulators are shared among multiple
> consumers or if regulators are marked as 'always_on'.
>
> Fix this by moving the some logic to the core, and put the regulator
> reference to the mmc_host struct and let it do its own supply state
> tracking so that the reference counting in the regulator won't get
> confused.
Looks like this patch got dropped because of the missing modifications
to arch/arm/mach-omap2/mmc-twl4030.c. Are we still interested in the
patch otherwise, and can anyone help with that?
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-08-27 19:03 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 12:46 [PATCH] mmc: move regulator handling to core Daniel Mack
2009-12-03 12:46 ` Daniel Mack
2009-12-03 13:06 ` Mark Brown
2009-12-03 13:06 ` Mark Brown
2009-12-03 13:14 ` Daniel Mack
2009-12-03 13:14 ` Daniel Mack
2009-12-03 13:22 ` Mark Brown
2009-12-03 13:22 ` Mark Brown
2009-12-03 13:32 ` Daniel Mack
2009-12-03 13:32 ` Daniel Mack
2009-12-03 13:40 ` Mark Brown
2009-12-03 13:40 ` Mark Brown
2009-12-03 13:43 ` Daniel Mack
2009-12-03 13:43 ` Daniel Mack
2009-12-03 14:58 ` Russell King - ARM Linux
2009-12-03 14:58 ` Russell King - ARM Linux
2009-12-03 15:09 ` Mark Brown
2009-12-03 15:09 ` Mark Brown
2009-12-03 14:27 ` Adrian Hunter
2009-12-03 14:27 ` Adrian Hunter
2009-12-03 19:20 ` Daniel Mack
2009-12-03 19:20 ` Daniel Mack
2009-12-03 20:12 ` Adrian Hunter
2009-12-03 20:12 ` Adrian Hunter
2009-12-04 11:58 ` Daniel Mack
2009-12-04 11:58 ` Daniel Mack
2009-12-12 0:58 ` Daniel Mack
2009-12-12 0:58 ` Daniel Mack
2009-12-14 17:43 ` Madhusudhan
2009-12-14 17:43 ` Madhusudhan
2009-12-14 17:43 ` Madhusudhan
2009-12-15 5:44 ` David Brownell
2009-12-15 5:44 ` David Brownell
2009-12-15 5:44 ` David Brownell
2010-08-27 19:03 ` Chris Ball [this message]
2010-08-27 19:03 ` Chris Ball
2010-08-28 14:48 ` Linus Walleij
2010-08-28 14:48 ` Linus Walleij
2010-08-29 13:27 ` Mark Brown
2010-08-29 13:27 ` Mark Brown
2010-08-29 15:30 ` Linus Walleij
2010-08-29 15:30 ` Linus Walleij
2010-08-31 11:07 ` Mark Brown
2010-08-31 11:07 ` Mark Brown
2010-08-31 12:15 ` Linus Walleij
2010-08-31 12:15 ` Linus Walleij
2010-08-31 12:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827190306.GB20407@void.printf.net \
--to=cjb@laptop.org \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbrake@bec-systems.com \
--cc=daniel@caiaq.de \
--cc=dbrownell@users.sourceforge.net \
--cc=eric.y.miao@gmail.com \
--cc=jarkko.lavinen@nokia.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=madhu.cr@ti.com \
--cc=matt@console-pimps.org \
--cc=pierre@ossman.eu \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.