From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Thomas Kleffel <tk@maintech.de>
Subject: Re: [PATCH 1/2] s3c24xx: DMA: don't use autoreload feature
Date: Fri, 27 Aug 2010 23:03:01 +0300 [thread overview]
Message-ID: <201008272303.10803.anarsoul@gmail.com> (raw)
In-Reply-To: <1282143866-8068-2-git-send-email-anarsoul@gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 797 bytes --]
В сообщении от 18 августа 2010 18:04:25 автор Vasily Khoruzhick написал:
> Some integrated DMA-capable hardware doesn't like autoreload
> feature of s3c24xx DMA-engine, that's why s3cmci driver
> didn't work with DMA transfers enabled.
>
> I rewrote DMA driver not to use autoreload feature and removed
> all pre-loading features. Buffer re-load is fast enought to perform
> it in IRQ handler, and anyway I don't see any reason to waste CPU
> cycles on waiting for buffer load. Driver is much simplier now,
> it was tested with s3cmci and s3c24xx-i2s drivers on s3c2442 and
> s3c2410 SoCs and works just nice.
Patch has problem with suspend/resume (chan->dcon is clobbered by
dma_sel->select())
Will resend fixed version soon.
Regards
Vasily
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] s3c24xx: DMA: don't use autoreload feature
Date: Fri, 27 Aug 2010 23:03:01 +0300 [thread overview]
Message-ID: <201008272303.10803.anarsoul@gmail.com> (raw)
In-Reply-To: <1282143866-8068-2-git-send-email-anarsoul@gmail.com>
? ????????? ?? 18 ??????? 2010 18:04:25 ????? Vasily Khoruzhick ???????:
> Some integrated DMA-capable hardware doesn't like autoreload
> feature of s3c24xx DMA-engine, that's why s3cmci driver
> didn't work with DMA transfers enabled.
>
> I rewrote DMA driver not to use autoreload feature and removed
> all pre-loading features. Buffer re-load is fast enought to perform
> it in IRQ handler, and anyway I don't see any reason to waste CPU
> cycles on waiting for buffer load. Driver is much simplier now,
> it was tested with s3cmci and s3c24xx-i2s drivers on s3c2442 and
> s3c2410 SoCs and works just nice.
Patch has problem with suspend/resume (chan->dcon is clobbered by
dma_sel->select())
Will resend fixed version soon.
Regards
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100827/ac1c701a/attachment.sig>
next prev parent reply other threads:[~2010-08-27 20:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 15:04 [PATCH 0/2] s3c24xx: fix DMA support for MCI Vasily Khoruzhick
2010-08-18 15:04 ` Vasily Khoruzhick
2010-08-18 15:04 ` [PATCH 1/2] s3c24xx: DMA: don't use autoreload feature Vasily Khoruzhick
2010-08-18 15:04 ` Vasily Khoruzhick
2010-08-27 20:03 ` Vasily Khoruzhick [this message]
2010-08-27 20:03 ` Vasily Khoruzhick
2010-08-27 20:04 ` [PATCH v2 " Vasily Khoruzhick
2010-08-27 20:04 ` Vasily Khoruzhick
2010-08-18 15:04 ` [PATCH 2/2] s3cmci: minor fixups Vasily Khoruzhick
2010-08-18 15:04 ` Vasily Khoruzhick
2010-08-24 13:23 ` [PATCH 0/2] s3c24xx: fix DMA support for MCI Vasily Khoruzhick
2010-08-24 13:23 ` Vasily Khoruzhick
-- strict thread matches above, loose matches on Subject: below --
2010-09-07 15:09 [PATCH 0/2] s3c24xx: fix s3cmci DMA support Vasily Khoruzhick
2010-09-07 23:23 ` [PATCH 1/2] s3c24xx: DMA: don't use autoreload feature Vasily Khoruzhick
2010-09-07 23:23 ` Vasily Khoruzhick
2010-09-07 23:37 ` Ben Dooks
2010-09-07 23:37 ` Ben Dooks
2010-09-08 6:27 ` Vasily Khoruzhick
2010-09-08 6:27 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008272303.10803.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tk@maintech.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.