Re: [PATCH] re-enable HVM PCI passthrough functionality

[Christoph Egger <Christoph.Egger@amd.com>]

On Tuesday 31 August 2010 11:17:27 Tim Deegan wrote:
> At 02:58 +0100 on 31 Aug (1283223494), Kay, Allen M wrote:
> > Attached patch reverts back to INVALID_MFN.  PCI passthrough
> > functionality works with this patch.
>
> Apologies for missing this - I did ask for this enormous patch to
> contain only what it said on the tin (and I did read it to check!) but
> this one got through.

Also apologies from my side. I did what Tim requested for, but that
one slipped through.

> > Signed-off-by: Allen Kay allen.m.kay@intel.com
>
> This is fine, but please add a comment explaining the rather subtle use
> of INVALID_MFN here so the next tidy-minded person doesn't "fix" it
> again. :)
>
> In fact would it be better to check the returned type == p2m_mmio_direct
> instead?  That seems like it would fit better with the intention.   Or
> do other callers use this to clean non-mmio entries too?

I'm interested in if this patch fixes the SR-IOV issue. We are still about
investigation...

Christoph



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632