From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bandan.das@stratus.com, herbert@gondor.hengli.com.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kaber@trash.net
Subject: Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip_fragment
Date: Wed, 01 Sep 2010 14:46:58 -0700 (PDT) [thread overview]
Message-ID: <20100901.144658.135972233.davem@davemloft.net> (raw)
In-Reply-To: <1283232031.2405.38.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 31 Aug 2010 07:20:31 +0200
> We could have a padding in front of struct br_input_skb_cb to make sure
> we dont overwrite IP (4|6) CB in bridge ?
>
> Something like this untested patch :
This will not help Brandan's case.
His packets are coming straight from TUN/TAP. They did not live in
the IP stack at all before hitting the bridge and then heading to
ip_fragment().
Therefore I'm inclined to agree with Herbert that we need to parse the
options explicitly before invoke ip_fragment(). We must call it with
an SKB in the state it expects, and that means with options parsing
already performed.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bandan.das@stratus.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kaber@trash.net
Subject: Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip_fragment
Date: Wed, 01 Sep 2010 14:46:58 -0700 (PDT) [thread overview]
Message-ID: <20100901.144658.135972233.davem@davemloft.net> (raw)
In-Reply-To: <1283232031.2405.38.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 31 Aug 2010 07:20:31 +0200
> We could have a padding in front of struct br_input_skb_cb to make sure
> we dont overwrite IP (4|6) CB in bridge ?
>
> Something like this untested patch :
This will not help Brandan's case.
His packets are coming straight from TUN/TAP. They did not live in
the IP stack at all before hitting the bridge and then heading to
ip_fragment().
Therefore I'm inclined to agree with Herbert that we need to parse the
options explicitly before invoke ip_fragment(). We must call it with
an SKB in the state it expects, and that means with options parsing
already performed.
next prev parent reply other threads:[~2010-09-01 21:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 20:09 [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip_fragment Bandan Das
2010-08-30 21:35 ` Eric Dumazet
2010-08-30 23:21 ` Bandan Das
2010-08-31 5:20 ` Eric Dumazet
2010-08-31 5:20 ` Eric Dumazet
2010-08-31 8:24 ` Herbert Xu
2010-08-31 8:24 ` Herbert Xu
2010-08-31 9:17 ` Eric Dumazet
2010-08-31 9:17 ` Eric Dumazet
2010-08-31 12:36 ` Herbert Xu
2010-08-31 12:36 ` Herbert Xu
2010-08-31 13:13 ` Eric Dumazet
2010-08-31 13:13 ` Eric Dumazet
2010-08-31 13:50 ` Bandan Das
2010-09-01 16:57 ` Bandan Das
2010-09-03 4:49 ` Herbert Xu
2010-09-03 4:49 ` Herbert Xu
2010-09-15 17:32 ` Bandan Das
2010-09-17 6:51 ` Herbert Xu
2010-09-17 6:51 ` Herbert Xu
2010-09-17 23:43 ` David Miller
2010-09-17 23:43 ` David Miller
2010-09-19 19:36 ` Bandan Das
2010-09-01 21:46 ` David Miller [this message]
2010-09-01 21:46 ` David Miller
2010-09-01 23:30 ` Herbert Xu
2010-09-01 23:30 ` Herbert Xu
2010-09-02 1:09 ` David Miller
2010-09-02 1:09 ` David Miller
2010-09-02 2:05 ` Bandan Das
2010-09-02 2:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901.144658.135972233.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bandan.das@stratus.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.hengli.com.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.