Re: [PATCH 1/5] USB: Add MSM USB Device Controller driver

[Pavan Kondeti <pkondeti@codeaurora.org>]

On Wed, Sep 01, 2010 at 10:03:54AM -0400, Alan Stern wrote:
> On Wed, 1 Sep 2010, Pavankumar Kondeti wrote:
> 
> > This patch adds the basic support for the USB Device Controller on Qualcomm
> > MSM family of SOCs.  The controller supports upto 16 endpoints including the
> > default endpoint (ep0).  All the data transfers are driven by DMA.
> > 
> > VBUS line is also connected to PMIC chip.  The module controlling PMIC chip
> > notifies about cable connect/disconnect events.  Hence, PHY comparators
> > are turned off in low power mode.
> > 
> > This driver was originally developed by Google and is available at
> > http://android.git.kernel.org/?p=kernel/experimental.git.
> 
> ...
> 
> > +static const struct usb_ep_ops msm72k_ep_ops = {
> > +	.enable		= msm72k_enable,
> > +	.disable	= msm72k_disable,
> > +
> > +	.alloc_request	= msm72k_alloc_request,
> > +	.free_request	= msm72k_free_request,
> > +
> > +	.queue		= msm72k_queue,
> > +	.dequeue	= msm72k_dequeue,
> > +
> > +	.set_halt	= msm72k_set_halt,
> > +	.fifo_flush	= msm72k_fifo_flush,
> > +};
> 
> The .set_wedge method is missing.
 
Thanks for pointing this out. I will implement this method.

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.