From: David Miller <davem@davemloft.net>
To: paulmck@linux.vnet.ibm.com
Cc: herbert@gondor.hengli.com.au, linville@tuxdriver.com,
netdev@vger.kernel.org, mingo@elte.hu,
linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH] netpoll: use non-BH variant of RCU
Date: Fri, 03 Sep 2010 08:34:09 -0700 (PDT) [thread overview]
Message-ID: <20100903.083409.52185570.davem@davemloft.net> (raw)
In-Reply-To: <20100902172625.GD2349@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date: Thu, 2 Sep 2010 10:26:25 -0700
> softirq: adjust error check
>
> The error check for _local_bh_enable_ip() warns on both in_irq() and
> irqs_disabled(). The check for in_irq() is necessary, because a hardirq
> might well have interrupted bh execution, in which case it is simply
> not possible for the hardirq to exclude the bh that got interrupted.
>
> However, it is perfectly reasonable to disable bh while hardirqs are
> disabled, and this in fact promotes common code. This commit therefore
> removes the irqs_disabled() check.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: David S. Miller <davem@davemloft.net>
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: paulmck@linux.vnet.ibm.com
Cc: herbert@gondor.apana.org.au, linville@tuxdriver.com,
netdev@vger.kernel.org, mingo@elte.hu,
linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH] netpoll: use non-BH variant of RCU
Date: Fri, 03 Sep 2010 08:34:09 -0700 (PDT) [thread overview]
Message-ID: <20100903.083409.52185570.davem@davemloft.net> (raw)
In-Reply-To: <20100902172625.GD2349@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date: Thu, 2 Sep 2010 10:26:25 -0700
> softirq: adjust error check
>
> The error check for _local_bh_enable_ip() warns on both in_irq() and
> irqs_disabled(). The check for in_irq() is necessary, because a hardirq
> might well have interrupted bh execution, in which case it is simply
> not possible for the hardirq to exclude the bh that got interrupted.
>
> However, it is perfectly reasonable to disable bh while hardirqs are
> disabled, and this in fact promotes common code. This commit therefore
> removes the irqs_disabled() check.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2010-09-03 15:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 20:25 [PATCH] netpoll: use non-BH variant of RCU John W. Linville
2010-08-10 20:43 ` Herbert Xu
2010-08-10 21:19 ` Paul E. McKenney
2010-08-10 23:31 ` David Miller
2010-08-11 11:03 ` Herbert Xu
2010-08-11 11:27 ` Herbert Xu
2010-08-11 15:37 ` John W. Linville
2010-08-12 6:16 ` David Miller
2010-08-11 12:20 ` Paul E. McKenney
2010-08-11 22:00 ` Paul E. McKenney
2010-08-12 6:09 ` David Miller
2010-08-12 15:42 ` Paul E. McKenney
2010-08-13 14:39 ` Herbert Xu
2010-08-13 16:29 ` Paul E. McKenney
2010-08-13 17:51 ` Herbert Xu
2010-08-13 17:51 ` Herbert Xu
2010-08-15 6:50 ` David Miller
2010-08-15 6:50 ` David Miller
2010-09-02 17:26 ` Paul E. McKenney
2010-09-02 17:26 ` Paul E. McKenney
2010-09-03 15:34 ` David Miller [this message]
2010-09-03 15:34 ` David Miller
2010-09-03 15:52 ` Paul E. McKenney
2010-09-03 15:52 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903.083409.52185570.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.