All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Eric B Munson <emunson@mgebm.net>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	akpm@linux-foundation.org, mingo@redhat.com,
	hugh.dickins@tiscali.co.uk, riel@redhat.com,
	peterz@infradead.org, anton@samba.org, hch@infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] Add trace points to mmap, munmap, and brk
Date: Fri, 3 Sep 2010 08:09:27 +0200	[thread overview]
Message-ID: <20100903060927.GA19074@elte.hu> (raw)
In-Reply-To: <20100902134827.GA6957@mgebm.net>


* Eric B Munson <emunson@mgebm.net> wrote:

> Sorry for the long delay, the enter/exit routines are not compatible 
> with the information that these new trace points provides.  When 
> tracing mmap, for instance, the addr and len arguments can be altered 
> by the function.  If you use the enter/exit trace points you would not 
> see this as the arguments are sampled at function entrance and not 
> given again on exit.  Also, the new trace points are only hit on 
> function success, the exit trace point happens any time you leave the 
> system call.

Would it be feasible to use enter/exit information as the main source of 
events - and only add new tracepoints for the _missing_ information? 
(such as when mmap arguments change)

Then user-space can combine the two. The new tracepoints would also 
carry useful information in themselves: they would show the cases where 
user-space did not get what it wished. (or so)

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Eric B Munson <emunson@mgebm.net>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	akpm@linux-foundation.org, mingo@redhat.com,
	hugh.dickins@tiscali.co.uk, riel@redhat.com,
	peterz@infradead.org, anton@samba.org, hch@infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] Add trace points to mmap, munmap, and brk
Date: Fri, 3 Sep 2010 08:09:27 +0200	[thread overview]
Message-ID: <20100903060927.GA19074@elte.hu> (raw)
In-Reply-To: <20100902134827.GA6957@mgebm.net>


* Eric B Munson <emunson@mgebm.net> wrote:

> Sorry for the long delay, the enter/exit routines are not compatible 
> with the information that these new trace points provides.  When 
> tracing mmap, for instance, the addr and len arguments can be altered 
> by the function.  If you use the enter/exit trace points you would not 
> see this as the arguments are sampled at function entrance and not 
> given again on exit.  Also, the new trace points are only hit on 
> function success, the exit trace point happens any time you leave the 
> system call.

Would it be feasible to use enter/exit information as the main source of 
events - and only add new tracepoints for the _missing_ information? 
(such as when mmap arguments change)

Then user-space can combine the two. The new tracepoints would also 
carry useful information in themselves: they would show the cases where 
user-space did not get what it wished. (or so)

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-09-03  6:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19 17:06 [PATCH 0/2 V2] Add trace points to [m|mun|mre]map and brk Eric B Munson
2010-07-19 17:06 ` Eric B Munson
2010-07-19 17:06 ` [PATCH 1/2] Add trace points to mmap, munmap, " Eric B Munson
2010-07-19 17:06   ` Eric B Munson
2010-07-21 13:34   ` KOSAKI Motohiro
2010-07-21 13:34     ` KOSAKI Motohiro
2010-07-27 11:09     ` Eric B Munson
2010-07-27 11:17       ` KOSAKI Motohiro
2010-07-27 11:17         ` KOSAKI Motohiro
2010-09-02 13:48         ` Eric B Munson
2010-09-03  2:37           ` KOSAKI Motohiro
2010-09-03  2:37             ` KOSAKI Motohiro
2010-09-03  6:09           ` Ingo Molnar [this message]
2010-09-03  6:09             ` Ingo Molnar
2010-07-19 17:06 ` [PATCH 2/2] Add mremap trace point Eric B Munson
2010-07-19 17:06   ` Eric B Munson
  -- strict thread matches above, loose matches on Subject: below --
2010-09-02 13:59 [PATCH 0/2 RESEND] Eric B Munson
2010-09-02 13:59 ` [PATCH 1/2] Add trace points to mmap, munmap, and brk Eric B Munson
2010-09-02 13:59   ` Eric B Munson
2010-09-03  2:40   ` KOSAKI Motohiro
2010-09-03  2:40     ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100903060927.GA19074@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=anton@samba.org \
    --cc=emunson@mgebm.net \
    --cc=hch@infradead.org \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.