* [PATCH] vhost: error handling fix
@ 2010-09-03 10:25 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2010-09-03 10:25 UTC (permalink / raw)
To: Michael S. Tsirkin, Tejun Heo, Eric Dumazet, Ingo Molnar, kvm,
virtualization, netdev, linux-kernel
vhost should set worker to NULL on cgroups attach failure,
so that we won't try to destroy the worker again on close.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Dave, no need to bother with this one unless you really want to -
I'll put it on my tree.
This is a follow up to Eric's patch - fixes error handling in a similar way.
drivers/vhost/vhost.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 7c75dce..666aa36 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -298,6 +298,7 @@ static long vhost_dev_set_owner(struct vhost_dev *dev)
return 0;
err_cgroup:
kthread_stop(worker);
+ dev->worker = NULL;
err_worker:
if (dev->mm)
mmput(dev->mm);
--
1.7.2.rc0.14.g41c1c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] vhost: error handling fix
@ 2010-09-03 10:25 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2010-09-03 10:25 UTC (permalink / raw)
To: Michael S. Tsirkin, Tejun Heo, Eric Dumazet, Ingo Molnar, kvm,
virtualization
vhost should set worker to NULL on cgroups attach failure,
so that we won't try to destroy the worker again on close.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Dave, no need to bother with this one unless you really want to -
I'll put it on my tree.
This is a follow up to Eric's patch - fixes error handling in a similar way.
drivers/vhost/vhost.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 7c75dce..666aa36 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -298,6 +298,7 @@ static long vhost_dev_set_owner(struct vhost_dev *dev)
return 0;
err_cgroup:
kthread_stop(worker);
+ dev->worker = NULL;
err_worker:
if (dev->mm)
mmput(dev->mm);
--
1.7.2.rc0.14.g41c1c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] vhost: error handling fix
@ 2010-09-03 10:25 Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2010-09-03 10:25 UTC (permalink / raw)
To: Michael S. Tsirkin, Tejun Heo, Eric Dumazet, Ingo Molnar, kvm,
virtualization@
vhost should set worker to NULL on cgroups attach failure,
so that we won't try to destroy the worker again on close.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Dave, no need to bother with this one unless you really want to -
I'll put it on my tree.
This is a follow up to Eric's patch - fixes error handling in a similar way.
drivers/vhost/vhost.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 7c75dce..666aa36 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -298,6 +298,7 @@ static long vhost_dev_set_owner(struct vhost_dev *dev)
return 0;
err_cgroup:
kthread_stop(worker);
+ dev->worker = NULL;
err_worker:
if (dev->mm)
mmput(dev->mm);
--
1.7.2.rc0.14.g41c1c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] vhost: error handling fix
@ 2010-09-03 10:25 Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2010-09-03 10:25 UTC (permalink / raw)
To: Michael S. Tsirkin, Tejun Heo, Eric Dumazet, Ingo Molnar, kvm,
virtualization
vhost should set worker to NULL on cgroups attach failure,
so that we won't try to destroy the worker again on close.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Dave, no need to bother with this one unless you really want to -
I'll put it on my tree.
This is a follow up to Eric's patch - fixes error handling in a similar way.
drivers/vhost/vhost.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 7c75dce..666aa36 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -298,6 +298,7 @@ static long vhost_dev_set_owner(struct vhost_dev *dev)
return 0;
err_cgroup:
kthread_stop(worker);
+ dev->worker = NULL;
err_worker:
if (dev->mm)
mmput(dev->mm);
--
1.7.2.rc0.14.g41c1c
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-03 10:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 10:25 [PATCH] vhost: error handling fix Michael S. Tsirkin
2010-09-03 10:25 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2010-09-03 10:25 Michael S. Tsirkin
2010-09-03 10:25 Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.