All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: mark gross <markgross@thegnar.org>,
	James Bottomley <James.Bottomley@suse.de>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] pm_qos_params: cleanup: terminate a string
Date: Fri, 03 Sep 2010 12:41:06 +0000	[thread overview]
Message-ID: <20100903124105.GJ5437@bicker> (raw)

This is just a picky thing, but we pass an possibly unterminated string
to printk if debugging is turned on.  Also printk level is set to
"debug" by pr_debug() so the "KERN_ERR" isn't used.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
index b7e4c36..310a51e 100644
--- a/kernel/pm_qos_params.c
+++ b/kernel/pm_qos_params.c
@@ -389,10 +389,11 @@ static ssize_t pm_qos_power_write(struct file *filp, const char __user *buf,
 	} else if (count = 11) { /* len('0x12345678/0') */
 		if (copy_from_user(ascii_value, buf, 11))
 			return -EFAULT;
+		ascii_value[10] = '\0';
 		x = sscanf(ascii_value, "%x", &value);
 		if (x != 1)
 			return -EINVAL;
-		pr_debug(KERN_ERR "%s, %d, 0x%x\n", ascii_value, x, value);
+		pr_debug("%s, %d, 0x%x\n", ascii_value, x, value);
 	} else
 		return -EINVAL;
 

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: mark gross <markgross@thegnar.org>,
	James Bottomley <James.Bottomley@suse.de>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] pm_qos_params: cleanup: terminate a string
Date: Fri, 3 Sep 2010 14:41:06 +0200	[thread overview]
Message-ID: <20100903124105.GJ5437@bicker> (raw)

This is just a picky thing, but we pass an possibly unterminated string
to printk if debugging is turned on.  Also printk level is set to
"debug" by pr_debug() so the "KERN_ERR" isn't used.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
index b7e4c36..310a51e 100644
--- a/kernel/pm_qos_params.c
+++ b/kernel/pm_qos_params.c
@@ -389,10 +389,11 @@ static ssize_t pm_qos_power_write(struct file *filp, const char __user *buf,
 	} else if (count == 11) { /* len('0x12345678/0') */
 		if (copy_from_user(ascii_value, buf, 11))
 			return -EFAULT;
+		ascii_value[10] = '\0';
 		x = sscanf(ascii_value, "%x", &value);
 		if (x != 1)
 			return -EINVAL;
-		pr_debug(KERN_ERR "%s, %d, 0x%x\n", ascii_value, x, value);
+		pr_debug("%s, %d, 0x%x\n", ascii_value, x, value);
 	} else
 		return -EINVAL;
 

             reply	other threads:[~2010-09-03 12:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-03 12:41 Dan Carpenter [this message]
2010-09-03 12:41 ` [patch] pm_qos_params: cleanup: terminate a string Dan Carpenter
2010-09-07  6:22 ` mark gross
2010-09-07  6:22   ` mark gross
2010-09-07 13:38   ` mark gross
2010-09-07 13:38     ` mark gross
2010-09-07 21:38     ` Dan Carpenter
2010-09-07 21:38       ` Dan Carpenter
2010-09-08 22:13     ` Rafael J. Wysocki
2010-09-08 22:13       ` Rafael J. Wysocki
2010-09-09  2:56       ` mark gross
2010-09-09  2:56         ` mark gross
2010-09-09 21:21         ` Rafael J. Wysocki
2010-09-09 21:21           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100903124105.GJ5437@bicker \
    --to=error27@gmail.com \
    --cc=James.Bottomley@suse.de \
    --cc=corbet@lwn.net \
    --cc=fweisbec@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@thegnar.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.