From: Andrew Morton <akpm@linux-foundation.org>
To: "Ira W. Snyder" <iws@ovro.caltech.edu>
Cc: Dan Williams <dan.j.williams@intel.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsldma: fix missing header include
Date: Fri, 3 Sep 2010 16:40:33 -0700 [thread overview]
Message-ID: <20100903164033.6ae37727.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100902194752.GA24861@ovro.caltech.edu>
On Thu, 2 Sep 2010 12:47:52 -0700
"Ira W. Snyder" <iws@ovro.caltech.edu> wrote:
> The slab.h header is required to use the kmalloc() family of functions.
> Due to recent kernel changes, this header must be directly included by
> code that calls into the memory allocator.
>
> Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> ---
>
> Without this patch, any code which includes this header fails to build.
>
> arch/powerpc/include/asm/fsldma.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/fsldma.h b/arch/powerpc/include/asm/fsldma.h
> index a67aeed..debc5ed 100644
> --- a/arch/powerpc/include/asm/fsldma.h
> +++ b/arch/powerpc/include/asm/fsldma.h
> @@ -11,6 +11,7 @@
> #ifndef __ARCH_POWERPC_ASM_FSLDMA_H__
> #define __ARCH_POWERPC_ASM_FSLDMA_H__
>
> +#include <linux/slab.h>
> #include <linux/dmaengine.h>
>
It also needs list.h, but appears to get it via sheer luck.
The functions in that header simply shouldn't have been inlined.
It's peculiar that fsl_dma_slave_append() hardwires GFP_ATOMIC, whereas
fsl_dma_slave_alloc() takes a gfp_t.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: "Ira W. Snyder" <iws@ovro.caltech.edu>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] fsldma: fix missing header include
Date: Fri, 3 Sep 2010 16:40:33 -0700 [thread overview]
Message-ID: <20100903164033.6ae37727.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100902194752.GA24861@ovro.caltech.edu>
On Thu, 2 Sep 2010 12:47:52 -0700
"Ira W. Snyder" <iws@ovro.caltech.edu> wrote:
> The slab.h header is required to use the kmalloc() family of functions.
> Due to recent kernel changes, this header must be directly included by
> code that calls into the memory allocator.
>
> Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> ---
>
> Without this patch, any code which includes this header fails to build.
>
> arch/powerpc/include/asm/fsldma.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/fsldma.h b/arch/powerpc/include/asm/fsldma.h
> index a67aeed..debc5ed 100644
> --- a/arch/powerpc/include/asm/fsldma.h
> +++ b/arch/powerpc/include/asm/fsldma.h
> @@ -11,6 +11,7 @@
> #ifndef __ARCH_POWERPC_ASM_FSLDMA_H__
> #define __ARCH_POWERPC_ASM_FSLDMA_H__
>
> +#include <linux/slab.h>
> #include <linux/dmaengine.h>
>
It also needs list.h, but appears to get it via sheer luck.
The functions in that header simply shouldn't have been inlined.
It's peculiar that fsl_dma_slave_append() hardwires GFP_ATOMIC, whereas
fsl_dma_slave_alloc() takes a gfp_t.
next prev parent reply other threads:[~2010-09-03 23:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 19:47 [PATCH] fsldma: fix missing header include Ira W. Snyder
2010-09-03 23:40 ` Andrew Morton [this message]
2010-09-03 23:40 ` Andrew Morton
2010-09-04 0:47 ` Ira W. Snyder
2010-09-04 0:47 ` Ira W. Snyder
2010-09-04 0:58 ` Andrew Morton
2010-09-04 0:58 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903164033.6ae37727.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.