From: Matt Fleming <matt@console-pimps.org>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Chris Ball <cjb@laptop.org>,
"r66093@freescale.com" <r66093@freescale.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Jerry Huang <Chang-Ming.Huang@freescale.com>
Subject: Re: [PATCH 3/3] MMC/SD: add callback function to detect card
Date: Sun, 5 Sep 2010 22:46:21 +0100 [thread overview]
Message-ID: <20100905214621.GA24748@console-pimps.org> (raw)
In-Reply-To: <4C7D5EA5.2060701@nokia.com>
On Tue, Aug 31, 2010 at 10:57:25PM +0300, Adrian Hunter wrote:
>
> But now I think it should be in the mmc_rescan() function
> because that is where the main other use of .get_cd()
> is, and also the only call of .detect().
That's a very good point. Aren't we duplicating the code in mmc_rescan()
with this patch? If there's something that mmc_rescan() isn't doing,
wouldn't it be better to modify that function instead of pushing it down
into the bus_ops detect functions?
prev parent reply other threads:[~2010-09-05 21:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 7:55 [PATCH 3/3] MMC/SD: add callback function to detect card r66093
2010-01-06 2:40 ` Huang Changming-R66093
2010-08-27 19:05 ` Chris Ball
2010-08-31 19:10 ` Matt Fleming
2010-08-31 19:23 ` Adrian Hunter
2010-08-31 19:38 ` Matt Fleming
2010-08-31 19:40 ` Adrian Hunter
2010-08-31 19:57 ` Adrian Hunter
2010-09-05 21:46 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100905214621.GA24748@console-pimps.org \
--to=matt@console-pimps.org \
--cc=Chang-Ming.Huang@freescale.com \
--cc=adrian.hunter@nokia.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r66093@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.