From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Julia Lawall <julia@diku.dk>, Ben Hutchings <ben@decadent.org.uk>,
Mike Gilks <mike.kernel@gilksonline.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/14] staging: rtl8192u: improve error path
Date: Mon, 06 Sep 2010 18:02:40 +0000 [thread overview]
Message-ID: <20100906180240.GC2764@bicker> (raw)
In-Reply-To: <20100906135055.GA9632@albatros>
On Mon, Sep 06, 2010 at 05:50:56PM +0400, Kulikov Vasiliy wrote:
> On Mon, Sep 06, 2010 at 12:11 +0200, Dan Carpenter wrote:
> > On Sun, Sep 05, 2010 at 10:32:41PM +0400, Kulikov Vasiliy wrote:
> > > +fail2:
> > > + rtl8192_down(dev);
> > > + if (priv->pFirmware) {
> > > + kfree(priv->pFirmware);
> > > + priv->pFirmware = NULL;
> > > + }
> > > + rtl8192_usb_deleteendpoints(dev);
> > > + destroy_workqueue(priv->priv_wq);
> > > + mdelay(10);
> >
> > What's this delay for?
>
> It was copied from rtl8192_usb_disconnect(), I don't know why it has
> mdelay(10). But it's better to keep the old deallocation code, it should
> have the same problems (if original code has any).
>
I think the delay in rtl8192_usb_disconnect() is because we reset the
device. (Of course, in that case, it would have been better to move the
delay into rtl8192_reset(). And also the reset code has been commented
out.)
In this case here, the delay is serves no purpose and should be removed.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Julia Lawall <julia@diku.dk>, Ben Hutchings <ben@decadent.org.uk>,
Mike Gilks <mike.kernel@gilksonline.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/14] staging: rtl8192u: improve error path
Date: Mon, 6 Sep 2010 20:02:40 +0200 [thread overview]
Message-ID: <20100906180240.GC2764@bicker> (raw)
In-Reply-To: <20100906135055.GA9632@albatros>
On Mon, Sep 06, 2010 at 05:50:56PM +0400, Kulikov Vasiliy wrote:
> On Mon, Sep 06, 2010 at 12:11 +0200, Dan Carpenter wrote:
> > On Sun, Sep 05, 2010 at 10:32:41PM +0400, Kulikov Vasiliy wrote:
> > > +fail2:
> > > + rtl8192_down(dev);
> > > + if (priv->pFirmware) {
> > > + kfree(priv->pFirmware);
> > > + priv->pFirmware = NULL;
> > > + }
> > > + rtl8192_usb_deleteendpoints(dev);
> > > + destroy_workqueue(priv->priv_wq);
> > > + mdelay(10);
> >
> > What's this delay for?
>
> It was copied from rtl8192_usb_disconnect(), I don't know why it has
> mdelay(10). But it's better to keep the old deallocation code, it should
> have the same problems (if original code has any).
>
I think the delay in rtl8192_usb_disconnect() is because we reset the
device. (Of course, in that case, it would have been better to move the
delay into rtl8192_reset(). And also the reset code has been commented
out.)
In this case here, the delay is serves no purpose and should be removed.
regards,
dan carpenter
next prev parent reply other threads:[~2010-09-06 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 18:32 [PATCH 06/14] staging: rtl8192u: improve error path Kulikov Vasiliy
2010-09-05 18:32 ` Kulikov Vasiliy
2010-09-06 10:11 ` Dan Carpenter
2010-09-06 10:11 ` Dan Carpenter
2010-09-06 13:50 ` Kulikov Vasiliy
2010-09-06 13:50 ` Kulikov Vasiliy
2010-09-06 18:02 ` Dan Carpenter [this message]
2010-09-06 18:02 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906180240.GC2764@bicker \
--to=error27@gmail.com \
--cc=ben@decadent.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mike.kernel@gilksonline.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.