All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"hpa@zytor.com" <hpa@zytor.com>, "mingo@elte.hu" <mingo@elte.hu>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [lm-sensors] [PATCH] x86/hwmon: fix configuration and
Date: Tue, 07 Sep 2010 08:03:03 +0000	[thread overview]
Message-ID: <20100907100303.2f45f227@hyperion.delvare> (raw)
In-Reply-To: <20100902212505.GA31811@fenghua-desk.sc.intel.com>

On Thu, 2 Sep 2010 14:25:05 -0700, Fenghua Yu wrote:
> On Thu, Sep 02, 2010 at 05:44:07AM -0700, Jan Beulich wrote:
> > - using cpuid_eax() to determine feature availability on other than
> >   the current CPU is invalid
> > - feature availability shopuld also be check in the hotplug code path
> > - pkgtemp doesn't depend on PCI altogether (apparently just inherited
> >   from coretemp)
> > - coretemp really only needs PCI for Atom support
> > 
> 
> Could you split the patch into small patches since it handles a few different
> things?

I can only second this request. This should be split into per-driver
patches or per-bug patches, or even both.

Jan, can you please send updated patches? I can't apply that one as is.
Thanks.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"hpa@zytor.com" <hpa@zytor.com>, "mingo@elte.hu" <mingo@elte.hu>,
	"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [lm-sensors] [PATCH] x86/hwmon: fix configuration and  initialization of coretemp and pkgtemp
Date: Tue, 7 Sep 2010 10:03:03 +0200	[thread overview]
Message-ID: <20100907100303.2f45f227@hyperion.delvare> (raw)
In-Reply-To: <20100902212505.GA31811@fenghua-desk.sc.intel.com>

On Thu, 2 Sep 2010 14:25:05 -0700, Fenghua Yu wrote:
> On Thu, Sep 02, 2010 at 05:44:07AM -0700, Jan Beulich wrote:
> > - using cpuid_eax() to determine feature availability on other than
> >   the current CPU is invalid
> > - feature availability shopuld also be check in the hotplug code path
> > - pkgtemp doesn't depend on PCI altogether (apparently just inherited
> >   from coretemp)
> > - coretemp really only needs PCI for Atom support
> > 
> 
> Could you split the patch into small patches since it handles a few different
> things?

I can only second this request. This should be split into per-driver
patches or per-bug patches, or even both.

Jan, can you please send updated patches? I can't apply that one as is.
Thanks.

-- 
Jean Delvare

  parent reply	other threads:[~2010-09-07  8:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-02 12:44 [lm-sensors] [PATCH] x86/hwmon: fix configuration and Jan Beulich
2010-09-02 12:44 ` [PATCH] x86/hwmon: fix configuration and initialization of coretemp and pkgtemp Jan Beulich
2010-09-02 21:25 ` [lm-sensors] [PATCH] x86/hwmon: fix configuration and Fenghua Yu
2010-09-02 21:25   ` [PATCH] x86/hwmon: fix configuration and initialization of coretemp and pkgtemp Fenghua Yu
2010-09-03  7:08   ` [lm-sensors] [PATCH] x86/hwmon: fix configuration and Jan Beulich
2010-09-03  7:08     ` [PATCH] x86/hwmon: fix configuration and initialization of coretemp and pkgtemp Jan Beulich
2010-09-07  8:03   ` Jean Delvare [this message]
2010-09-07  8:03     ` [lm-sensors] " Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100907100303.2f45f227@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=JBeulich@novell.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.