From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: error27@gmail.com, sri@us.ibm.com, yjwei@cn.fujitsu.com,
cascardo@holoscopio.com, linux-sctp@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] sctp: fix test for end of loop
Date: Wed, 08 Sep 2010 20:30:45 +0000 [thread overview]
Message-ID: <20100908.133045.245384362.davem@davemloft.net> (raw)
In-Reply-To: <4C87F185.3070402@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 08 Sep 2010 16:26:45 -0400
> I am really not fond of this code. I think it would be better to move
> this abort code into the loop and break out once things are aborted.
>
> This way we can get rid of the whole found check after the outer loop happens
> and it cleans things up nicely.
Vlad see my followup.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: error27@gmail.com, sri@us.ibm.com, yjwei@cn.fujitsu.com,
cascardo@holoscopio.com, linux-sctp@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] sctp: fix test for end of loop
Date: Wed, 08 Sep 2010 13:30:45 -0700 (PDT) [thread overview]
Message-ID: <20100908.133045.245384362.davem@davemloft.net> (raw)
In-Reply-To: <4C87F185.3070402@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 08 Sep 2010 16:26:45 -0400
> I am really not fond of this code. I think it would be better to move
> this abort code into the loop and break out once things are aborted.
>
> This way we can get rid of the whole found check after the outer loop happens
> and it cleans things up nicely.
Vlad see my followup.
next prev parent reply other threads:[~2010-09-08 20:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 12:26 [patch] sctp: fix test for end of loop Dan Carpenter
2010-09-06 12:26 ` Dan Carpenter
2010-09-07 8:46 ` Shan Wei
2010-09-07 8:46 ` Shan Wei
2010-09-07 11:31 ` Dan Carpenter
2010-09-07 11:31 ` Dan Carpenter
2010-09-08 20:24 ` David Miller
2010-09-08 20:24 ` David Miller
2010-09-08 20:34 ` Vlad Yasevich
2010-09-08 20:34 ` Vlad Yasevich
2010-09-08 20:37 ` David Miller
2010-09-08 20:37 ` David Miller
2010-09-08 21:04 ` [Alternative PATCH net-next] " Joe Perches
2010-09-08 21:04 ` Joe Perches
2010-09-09 13:57 ` Vlad Yasevich
2010-09-09 13:57 ` Vlad Yasevich
2010-09-09 22:00 ` David Miller
2010-09-09 22:00 ` David Miller
2010-09-08 20:26 ` [patch] " Vlad Yasevich
2010-09-08 20:26 ` Vlad Yasevich
2010-09-08 20:30 ` David Miller [this message]
2010-09-08 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908.133045.245384362.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cascardo@holoscopio.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
--cc=vladislav.yasevich@hp.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.