From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] rx1950: add battery device
Date: Wed, 8 Sep 2010 02:10:05 +0300 [thread overview]
Message-ID: <201009080210.12621.anarsoul@gmail.com> (raw)
In-Reply-To: <4C86C56B.7090204@fluff.org>
[-- Attachment #1: Type: Text/Plain, Size: 1190 bytes --]
В сообщении от 8 сентября 2010 02:06:19 автор Ben Dooks написал:
> On 07/09/10 15:32, Vasily Khoruzhick wrote:
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > ---
> >
> > arch/arm/mach-s3c2440/Kconfig | 3 +
> > arch/arm/mach-s3c2440/mach-rx1950.c | 160
> > +++++++++++++++++++++++++++++++++++ 2 files changed, 163 insertions(+),
> > 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-s3c2440/Kconfig
> > b/arch/arm/mach-s3c2440/Kconfig index cd8e7de..9b6b026 100644
> > --- a/arch/arm/mach-s3c2440/Kconfig
> > +++ b/arch/arm/mach-s3c2440/Kconfig
> > @@ -198,6 +198,9 @@ config MACH_RX1950
> >
> > select S3C_DEV_NAND
> > select S3C2410_IOTIMING if S3C2440_CPUFREQ
> > select S3C2440_XTAL_16934400
> >
> > + select S3C_ADC
> > + select PDA_POWER
> > + select BATTERY_S3C_ADC
>
> not keen on forcing these on unless they are required for the
> system to work.
Ok
> > + {3629, 178, 10},
> > + {3612, 162, 5},
> > + {3605, 162, 0},
> > +
>
> at least add a space after { and before }
> it would be nice to have named initialisers.
Ok, I'll add named initialisers
Regards
Vasily
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] rx1950: add battery device
Date: Wed, 8 Sep 2010 02:10:05 +0300 [thread overview]
Message-ID: <201009080210.12621.anarsoul@gmail.com> (raw)
In-Reply-To: <4C86C56B.7090204@fluff.org>
? ????????? ?? 8 ???????? 2010 02:06:19 ????? Ben Dooks ???????:
> On 07/09/10 15:32, Vasily Khoruzhick wrote:
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > ---
> >
> > arch/arm/mach-s3c2440/Kconfig | 3 +
> > arch/arm/mach-s3c2440/mach-rx1950.c | 160
> > +++++++++++++++++++++++++++++++++++ 2 files changed, 163 insertions(+),
> > 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-s3c2440/Kconfig
> > b/arch/arm/mach-s3c2440/Kconfig index cd8e7de..9b6b026 100644
> > --- a/arch/arm/mach-s3c2440/Kconfig
> > +++ b/arch/arm/mach-s3c2440/Kconfig
> > @@ -198,6 +198,9 @@ config MACH_RX1950
> >
> > select S3C_DEV_NAND
> > select S3C2410_IOTIMING if S3C2440_CPUFREQ
> > select S3C2440_XTAL_16934400
> >
> > + select S3C_ADC
> > + select PDA_POWER
> > + select BATTERY_S3C_ADC
>
> not keen on forcing these on unless they are required for the
> system to work.
Ok
> > + {3629, 178, 10},
> > + {3612, 162, 5},
> > + {3605, 162, 0},
> > +
>
> at least add a space after { and before }
> it would be nice to have named initialisers.
Ok, I'll add named initialisers
Regards
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100908/c04cdb87/attachment.sig>
next prev parent reply other threads:[~2010-09-07 23:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 14:32 [PATCH 0/3] rx1950: add rest of devices Vasily Khoruzhick
2010-09-07 14:32 ` Vasily Khoruzhick
2010-09-07 14:32 ` [PATCH 1/3] rx1950: add battery device Vasily Khoruzhick
2010-09-07 14:32 ` Vasily Khoruzhick
2010-09-07 23:06 ` Ben Dooks
2010-09-07 23:06 ` Ben Dooks
2010-09-07 23:10 ` Vasily Khoruzhick [this message]
2010-09-07 23:10 ` Vasily Khoruzhick
2010-09-08 8:58 ` [PATCH v2 " Vasily Khoruzhick
2010-09-08 8:58 ` Vasily Khoruzhick
2010-09-25 23:48 ` Ben Dooks
2010-09-25 23:48 ` Ben Dooks
2010-09-26 21:17 ` [PATCH v3 " Vasily Khoruzhick
2010-09-26 21:17 ` Vasily Khoruzhick
2010-09-07 14:32 ` [PATCH 2/3] rx1950: add LEDs support Vasily Khoruzhick
2010-09-07 14:32 ` Vasily Khoruzhick
2010-09-07 14:32 ` [PATCH 3/3] rx1950: add UDA1380 to i2c devices list Vasily Khoruzhick
2010-09-07 14:32 ` Vasily Khoruzhick
2010-09-07 23:07 ` [PATCH 0/3] rx1950: add rest of devices Ben Dooks
2010-09-07 23:07 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009080210.12621.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.